feat: 낙관적 업데이트 이후 실패 시 롤백 로직 구현

Author: opficdev

Application/DevLogPresentation/Sources/PushNotification/PushNotificationListFeature.swift

@@ -78,6 +78,7 @@ struct PushNotificationListFeature {
             case setHasMore(Bool)
             case syncNotifications([PushNotificationItem], nextCursor: PushNotificationCursor?, hasMore: Bool)
             case setNotificationHidden(String, Bool)
+            case setNotificationRead(String, Bool)
             case observeNotifications(PushNotificationQuery, Int)
         }
     }
@@ -156,8 +157,9 @@ private extension PushNotificationListFeature {
             guard let index = state.notifications.firstIndex(where: { $0.id == item.id }) else {
                 return .none
             }
-            state.notifications[index].isRead.toggle()
-            return toggleReadEffect(item.todoId)
+            let isRead = !state.notifications[index].isRead
+            state.notifications[index].isRead = isRead
+            return toggleReadEffect(notificationId: item.id, todoId: item.todoId, rollbackRead: !isRead)
         case .undoDelete:
             guard let undoNotificationId = state.undoNotificationId else { return .none }
             Self.setNotificationHidden(&state, notificationId: undoNotificationId, isHidden: false)
@@ -190,6 +192,10 @@ private extension PushNotificationListFeature {
             state.hasMore = hasMore
         case .store(.setNotificationHidden(let notificationId, let isHidden)):
             Self.setNotificationHidden(&state, notificationId: notificationId, isHidden: isHidden)
+        case .store(.setNotificationRead(let notificationId, let isRead)):
+            if let index = state.notifications.firstIndex(where: { $0.id == notificationId }) {
+                state.notifications[index].isRead = isRead
+            }
         case .toggleSortOption:
             state.query.sortOrder = state.query.sortOrder == .latest ? .oldest : .latest
             state.nextCursor = nil
@@ -216,7 +222,7 @@ private extension PushNotificationListFeature {
             state.selectedTodoId = TodoIdItem(id: item.todoId)
             guard !item.isRead else { return .none }
             state.notifications[index].isRead = true
-            return toggleReadEffect(item.todoId)
+            return toggleReadEffect(notificationId: item.id, todoId: item.todoId, rollbackRead: false)
         case .syncSheetPresentation(let isCompactLayout):
             if let todoId = state.selectedTodoId?.id, isCompactLayout {
                 state.sheet = .init(todoId: todoId)
@@ -320,13 +326,18 @@ private extension PushNotificationListFeature {
         }
     }
 
-    func toggleReadEffect(_ todoId: String) -> Effect<Action> {
+    func toggleReadEffect(
+        notificationId: String,
+        todoId: String,
+        rollbackRead: Bool
+    ) -> Effect<Action> {
         .run { [togglePushNotificationReadUseCase] send in
             await send(.loading(.begin(target: .default, mode: .delayed)))
             do {
                 try await togglePushNotificationReadUseCase.execute(todoId)
                 await send(.loading(.end(target: .default, mode: .delayed)))
             } catch {
+                await send(.store(.setNotificationRead(notificationId, rollbackRead)))
                 await send(.loading(.end(target: .default, mode: .delayed)))
                 await send(.store(.setAlert))
             }

Application/DevLogPresentation/Tests/PushNotification/PushNotificationListFeatureTests.swift

@@ -100,6 +100,33 @@ struct PushNotificationListFeatureTests {
         )
     }
 
+    @Test("toggleRead 실패 시 읽음 상태를 원래 값으로 롤백한다")
+    func toggleRead_실패_시_읽음_상태를_원래_값으로_롤백한다() async throws {
+        struct DummyError: Error {}
+
+        let fetchSpy = PushNotificationListFetchUseCaseSpy(pages: [
+            PushNotificationPage(
+                items: [
+                    makePushNotification(id: "notification-1", number: 1, isRead: true)
+                ],
+                nextCursor: nil
+            )
+        ])
+        let toggleSpy = TogglePushNotificationReadUseCaseSpy()
+        toggleSpy.error = DummyError()
+        let adapter = PushNotificationListStoreTestAdapter(
+            fetchUseCase: fetchSpy,
+            toggleReadUseCase: toggleSpy
+        )
+
+        await adapter.fetchNotifications()
+        let item = try #require(adapter.notifications.first)
+
+        await adapter.toggleRead(item)
+
+        #expect(adapter.notifications.first?.isRead == true)
+    }
+
     @Test("syncSheetPresentation은 layout에 따라 시트 상태를 동기화한다")
     func syncSheetPresentation은_layout에_따라_시트_상태를_동기화한다() async throws {
         let fetchSpy = PushNotificationListFetchUseCaseSpy(pages: [

Application/DevLogPresentation/Tests/Support/TestSupport.swift

@@ -107,9 +107,13 @@ final class UndoDeletePushNotificationUseCaseSpy: UndoDeletePushNotificationUseC
 
 final class TogglePushNotificationReadUseCaseSpy: TogglePushNotificationReadUseCase {
     private(set) var calledTodoIds: [String] = []
+    var error: Error?
 
     func execute(_ todoId: String) async throws {
         calledTodoIds.append(todoId)
+        if let error {
+            throw error
+        }
     }
 }