[#284] 탭뷰에 있는 알림 이미지에 읽지 않은 푸시알림 데이터가 있을 경우 해당 데이터의 갯수를 배지로 보이도록 구현한다 #290
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| // | ||
| // ObserveUnreadPushCountUseCase.swift | ||
| // DevLog | ||
| // | ||
| // Created by opfic on 3/17/26. | ||
| // | ||
|
|
||
| import Combine | ||
|
|
||
| protocol ObserveUnreadPushCountUseCase { | ||
| func execute() throws -> AnyPublisher<Int, Error> | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| // | ||
| // ObserveUnreadPushCountUseCaseImpl.swift | ||
| // DevLog | ||
| // | ||
| // Created by opfic on 3/17/26. | ||
| // | ||
|
|
||
| import Combine | ||
|
|
||
| final class ObserveUnreadPushCountUseCaseImpl: ObserveUnreadPushCountUseCase { | ||
| private let repository: PushNotificationRepository | ||
|
|
||
| init(_ repository: PushNotificationRepository) { | ||
| self.repository = repository | ||
| } | ||
|
|
||
| func execute() throws -> AnyPublisher<Int, Error> { | ||
| try repository.observeUnreadPushCount() | ||
| .removeDuplicates() | ||
| .eraseToAnyPublisher() | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,99 @@ | ||
| // | ||
| // MainViewModel.swift | ||
| // DevLog | ||
| // | ||
| // Created by opfic on 3/17/26. | ||
| // | ||
|
|
||
| import Foundation | ||
| import Combine | ||
| import UserNotifications | ||
|
|
||
| @Observable | ||
| final class MainViewModel: Store { | ||
| struct State: Equatable { | ||
| var unreadPushCount = 0 | ||
| var showAlert = false | ||
| var alertTitle = "" | ||
| var alertMessage = "" | ||
| } | ||
|
|
||
| enum Action { | ||
| case setUnreadPushCount(Int) | ||
| case setAlert(Bool) | ||
| } | ||
|
|
||
| enum SideEffect { | ||
| case updateBadgeCount(Int) | ||
| } | ||
|
|
||
| private(set) var state = State() | ||
| private var cancellables = Set<AnyCancellable>() | ||
| private let observeUnreadPushCountUseCase: ObserveUnreadPushCountUseCase | ||
|
|
||
| init( | ||
| observeUnreadPushCountUseCase: ObserveUnreadPushCountUseCase | ||
| ) { | ||
| self.observeUnreadPushCountUseCase = observeUnreadPushCountUseCase | ||
| observeUnreadPushCount() | ||
| } | ||
|
Comment on lines
+38
to
+42
Contributor
There was a problem hiding this comment.
deinit {
updateBadgeCount(0)
} |
||
|
|
||
| func reduce(with action: Action) -> [SideEffect] { | ||
| var state = self.state | ||
| var sideEffects: [SideEffect] = [] | ||
|
|
||
| switch action { | ||
| case .setUnreadPushCount(let count): | ||
| state.unreadPushCount = count | ||
| sideEffects = [.updateBadgeCount(count)] | ||
| case .setAlert(let isPresented): | ||
| setAlert(&state, isPresented: isPresented) | ||
| } | ||
|
|
||
| if self.state != state { self.state = state } | ||
| return sideEffects | ||
| } | ||
|
|
||
| func run(_ effect: SideEffect) { | ||
| switch effect { | ||
| case .updateBadgeCount(let count): | ||
| updateBadgeCount(count) | ||
| } | ||
| } | ||
| } | ||
|
|
||
| private extension MainViewModel { | ||
| func setAlert( | ||
| _ state: inout State, | ||
| isPresented: Bool | ||
| ) { | ||
| state.alertTitle = "오류" | ||
| state.alertMessage = "알림 배지를 불러오는 중 문제가 발생했습니다." | ||
| state.showAlert = isPresented | ||
| } | ||
|
|
||
| func observeUnreadPushCount() { | ||
| do { | ||
| try observeUnreadPushCountUseCase.execute() | ||
| .receive(on: DispatchQueue.main) | ||
| .sink( | ||
| receiveCompletion: { [weak self] completion in | ||
| guard let self else { return } | ||
| if case .failure = completion { | ||
| self.send(.setAlert(true)) | ||
| } | ||
| }, | ||
| receiveValue: { [weak self] count in | ||
| self?.send(.setUnreadPushCount(count)) | ||
| } | ||
| ) | ||
| .store(in: &cancellables) | ||
| } catch { | ||
| send(.setAlert(true)) | ||
| } | ||
| } | ||
|
|
||
| func updateBadgeCount(_ count: Int) { | ||
| UNUserNotificationCenter.current().setBadgeCount(count) { _ in } | ||
| } | ||
|
Comment on lines
+108
to
+114
Contributor
There was a problem hiding this comment.
// In MainViewModel
private let logger = Logger(category: "MainViewModel")
// ...
func updateBadgeCount(_ count: Int) {
UNUserNotificationCenter.current().setBadgeCount(count) { [weak self] error in
if let error {
self?.logger.error("Failed to update badge count", error: error)
}
}
} |
||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RootView의body에서MainViewModel(...)를 직접 만들면RootViewModel상태 변경(세션/테마/네트워크 등)마다 새 인스턴스가 계속 생성됩니다.MainViewModel.init이 즉시observeUnreadPushCount()를 실행해 Firestore 구독을 시작하므로, 실제로는MainView의@State에 채택되지 않고 버려지는 인스턴스에서도 불필요한 리스너 등록/해제가 반복되어 성능과 네트워크 비용이 증가합니다.Useful? React with 👍 / 👎.