[#415] 위젯 싱크 트리거를 수정한다#511
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces widget synchronization functionality by adding WidgetSessionSyncHandler to observe login session changes and publishing sync events from TodoRepositoryImpl and UserPreferencesRepositoryImpl upon data modifications. Review feedback suggests maintaining the original objectVersion in the Xcode project file to minimize version control noise and ensuring thread safety in WidgetSessionSyncHandler by receiving events on the main queue to prevent potential data races.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 연관된 이슈
🎯 의도
📝 작업 내용
📌 요약
🔍 상세
TodoRepositoryImpl에서upsertTodo,deleteTodo,undoDeleteTodo성공 이후WidgetSyncEventBus로.syncRequested발행UserPreferencesRepositoryImpl에서setHeatmapActivityTypes,setTodayDisplayOptions성공 이후 위젯 동기화 요청 발행WidgetSessionSyncHandler추가로 로그인 세션true첫 진입 시 위젯 동기화 요청 처리PushNotificationOpenHandler의 analytics 기록 의존성을TrackAnalyticsEventUseCase에서AnalyticsService로 변경📸 영상 / 이미지 (Optional)