[#630] Presentation 레이어의 ci 테스트에 걸리는 시간을 개선한다#631
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors AccountFeatureTests.swift to use TestStore directly for testing account linking, simplifying the test driver helper. The review feedback suggests maintaining exhaustive testing by removing store.exhaustivity = .off since all state changes and actions are already fully asserted.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 연관된 이슈
🎯 의도
CI에서
Persistence-Presentation테스트 job이 병목이 되는 문제 완화📝 작업 내용
📌 요약
DevLogPersistence와DevLogPresentation테스트 job 분리AccountFeatureTests의 지연 로딩 테스트에서waitUntil폴링 제거TestStore.receive기반 액션 검증으로 테스트 대기 시간 단축🔍 상세
.github/workflows/ci.yml의Persistence-Presentationmatrix를Persistence,Presentation으로 분리AccountFeatureTests의연동 작업이 지연되면 로딩 상태를 표시하고 완료되면 해제한다테스트를AccountTestDriver기반 상태 폴링에서TestStore기반 액션 수신 검증으로 변경loading.begin,loading.delayedLoadingDidBecomeVisible,setProviders,loading.end액션 순서를 직접 검증하도록 수정DevLogPresentationTests/AccountFeatureTests단독 테스트 통과📸 영상 / 이미지 (Optional)