Merge branch 'develop' into docs/#211-readme

Author: opficdev

.gemini/styleguide.md

@@ -1,2 +1,9 @@
-# 지침사항
-당신은 iOS 수석 개발자 입니다. 당신은 한국인 이므로 코드 리뷰 및 요약을 한국어로 해야 합니다.
+## Review Guidelines
+
+- Write all review comments in Korean.
+- Keep review comments concise and high-signal.
+- Prioritize findings about bugs, performance, and readability.
+- Do not explain obvious, trivial, or low-signal issues.
+- When useful, begin the review with a short summary of the main changes.
+- Focus on actionable feedback rather than broad commentary.
+

.github/workflows/build.yml

@@ -16,36 +16,7 @@ permissions:
   checks: write
 
 jobs:
-  detect_qa_tag:
-    runs-on: macos-latest
-    outputs:
-      has_qa_tag: ${{ steps.detect.outputs.has_qa_tag }}
-    steps:
-      - uses: actions/checkout@v5
-        with:
-          fetch-depth: 0
-          fetch-tags: true
-
-      - name: Detect QA Tag on PR Head
-        id: detect
-        shell: bash
-        run: |
-          set -euo pipefail
-          PR_HEAD_SHA="${{ github.event.pull_request.head.sha }}"
-          MATCHED_TAG="$(git tag --points-at "$PR_HEAD_SHA" | grep -E '^qa(-local)?-' | head -n 1 || true)"
-
-          if [ -n "$MATCHED_TAG" ]; then
-            echo "Found QA tag on PR head: $MATCHED_TAG"
-            echo "has_qa_tag=true" >> "$GITHUB_OUTPUT"
-            exit 0
-          fi
-
-          echo "No QA tag found on PR head"
-          echo "has_qa_tag=false" >> "$GITHUB_OUTPUT"
-
   build:
-    needs: detect_qa_tag
-    if: needs.detect_qa_tag.outputs.has_qa_tag != 'true'
     runs-on: macos-latest
     timeout-minutes: 30
     steps:
@@ -206,15 +177,6 @@ jobs:
           XC_STATUS=${PIPESTATUS[0]}
           set -e
 
-          if [ -f build.log ]; then
-            echo "== error: lines =="
-            if grep -i "error:" build.log; then
-              if [ "$XC_STATUS" -eq 0 ]; then
-                XC_STATUS=1
-              fi
-            fi
-          fi
-
           exit $XC_STATUS
 
       - name: Comment build failure on PR
@@ -228,9 +190,9 @@ jobs:
             if (fs.existsSync(path)) {
               const log = fs.readFileSync(path, 'utf8');
               const lines = log.split(/\r?\n/);
-              const errorLines = lines.filter((line) => /error:/i.test(line));
+              const errorLines = lines.filter((line) => /^(.*?):(\d+):(\d+):\s+error:/i.test(line));
               if (errorLines.length > 0) {
-                body += "Lines containing 'error:':\n\n```\n" + errorLines.join('\n') + '\n```\n';
+                body += "Compiler error lines:\n\n```\n" + errorLines.join('\n') + '\n```\n';
 
                 const repoRoot = process.env.GITHUB_WORKSPACE || process.cwd();
                 const pathMod = require('path');
@@ -258,7 +220,7 @@ jobs:
                   body += "\nCode excerpts:\n\n```\n" + snippets.join('\n\n') + "\n```\n";
                 }
               } else {
-                body += "No lines containing 'error:' were found in build.log.";
+                body += "No compiler-style error diagnostics were found in build.log.";
               }
             } else {
               body += 'build.log not found.';

.github/workflows/testflight.yml

@@ -1,10 +1,11 @@
 name: iOS TestFlight
 
 on:
-  push:
-    tags:
-      - "qa-*"
-  workflow_dispatch:
+  pull_request:
+    types:
+      - closed
+    branches:
+      - develop
 
 env:
   SCHEME: DevLog
@@ -24,12 +25,15 @@ permissions:
 
 jobs:
   testflight:
+    if: github.event.pull_request.merged == true && github.event.pull_request.base.ref == 'develop' && (contains(github.event.pull_request.labels.*.name, 'qa') || contains(github.event.pull_request.labels.*.name, 'qa-local'))
     runs-on: macos-latest
     timeout-minutes: 45
 
     steps:
-      - name: Checkout
+      - name: Checkout merge commit
         uses: actions/checkout@v5
+        with:
+          ref: ${{ github.event.pull_request.merge_commit_sha }}
 
       - name: Install private config files
         uses: ./.github/actions/install-private-config
@@ -74,10 +78,10 @@ jobs:
       - name: Build for TestFlight
         run: bundle exec fastlane testflight_build_only
 
-      - name: Skip TestFlight Upload for Local QA Tag
-        if: github.event_name == 'push' && startsWith(github.ref_name, 'qa-local-')
-        run: echo "Skipping TestFlight upload for local QA tag ${GITHUB_REF_NAME}"
+      - name: Skip TestFlight Upload for Local QA Label
+        if: contains(github.event.pull_request.labels.*.name, 'qa-local')
+        run: echo "Skipping TestFlight upload for PR labeled qa-local"
 
       - name: Upload to TestFlight
-        if: github.event_name != 'push' || !startsWith(github.ref_name, 'qa-local-')
+        if: contains(github.event.pull_request.labels.*.name, 'qa') && !contains(github.event.pull_request.labels.*.name, 'qa-local')
         run: bundle exec fastlane upload_testflight_build

DevLog.xcodeproj/project.pbxproj

@@ -15,28 +15,13 @@
 		DFABA3B02E23526500FEFBDB /* FirebaseFirestore in Frameworks */ = {isa = PBXBuildFile; productRef = DFABA3AF2E23526500FEFBDB /* FirebaseFirestore */; };
 		DFABA3B22E23526500FEFBDB /* FirebaseFunctions in Frameworks */ = {isa = PBXBuildFile; productRef = DFABA3B12E23526500FEFBDB /* FirebaseFunctions */; };
 		DFABA3B42E23526500FEFBDB /* FirebaseMessaging in Frameworks */ = {isa = PBXBuildFile; productRef = DFABA3B32E23526500FEFBDB /* FirebaseMessaging */; };
-		DFD643A72EC787AB0073E133 /* firebase.json in Resources */ = {isa = PBXBuildFile; fileRef = DFD643A42EC787AB0073E133 /* firebase.json */; };
-		DFD643A92EC787AB0073E133 /* package.json in Resources */ = {isa = PBXBuildFile; fileRef = DFD643A02EC787AB0073E133 /* package.json */; };
-		DFD643AC2EC787AB0073E133 /* tsconfig.json in Resources */ = {isa = PBXBuildFile; fileRef = DFD643A22EC787AB0073E133 /* tsconfig.json */; };
-		DFD643AE2EC787AB0073E133 /* package-lock.json in Resources */ = {isa = PBXBuildFile; fileRef = DFD643A12EC787AB0073E133 /* package-lock.json */; };
 		DFD645402EC827A10073E133 /* .gitignore in Resources */ = {isa = PBXBuildFile; fileRef = DFD6453F2EC827A10073E133 /* .gitignore */; };
 		DFD74E2F2E423EA700613803 /* README.md in Resources */ = {isa = PBXBuildFile; fileRef = DFD74E2E2E423EA700613803 /* README.md */; };
 		DFF2DACE2EDC02AD00778738 /* OrderedCollections in Frameworks */ = {isa = PBXBuildFile; productRef = DFF2DACD2EDC02AD00778738 /* OrderedCollections */; };
 /* End PBXBuildFile section */
 
 /* Begin PBXFileReference section */
 		DFD48B002DC4D6E2005905C5 /* DevLog.app */ = {isa = PBXFileReference; explicitFileType = wrapper.application; includeInIndex = 0; path = DevLog.app; sourceTree = BUILT_PRODUCTS_DIR; };
-		DFD643952EC787AB0073E133 /* apple.ts */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.typescript; path = apple.ts; sourceTree = "<group>"; };
-		DFD643962EC787AB0073E133 /* github.ts */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.typescript; path = github.ts; sourceTree = "<group>"; };
-		DFD643972EC787AB0073E133 /* google.ts */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.typescript; path = google.ts; sourceTree = "<group>"; };
-		DFD643992EC787AB0073E133 /* notification.ts */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.typescript; path = notification.ts; sourceTree = "<group>"; };
-		DFD6439A2EC787AB0073E133 /* schedule.ts */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.typescript; path = schedule.ts; sourceTree = "<group>"; };
-		DFD6439C2EC787AB0073E133 /* delete.ts */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.typescript; path = delete.ts; sourceTree = "<group>"; };
-		DFD6439E2EC787AB0073E133 /* index.ts */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.typescript; path = index.ts; sourceTree = "<group>"; };
-		DFD643A02EC787AB0073E133 /* package.json */ = {isa = PBXFileReference; lastKnownFileType = text.json; path = package.json; sourceTree = "<group>"; };
-		DFD643A12EC787AB0073E133 /* package-lock.json */ = {isa = PBXFileReference; lastKnownFileType = text.json; path = "package-lock.json"; sourceTree = "<group>"; };
-		DFD643A22EC787AB0073E133 /* tsconfig.json */ = {isa = PBXFileReference; lastKnownFileType = text.json; path = tsconfig.json; sourceTree = "<group>"; };
-		DFD643A42EC787AB0073E133 /* firebase.json */ = {isa = PBXFileReference; lastKnownFileType = text.json; path = firebase.json; sourceTree = "<group>"; };
 		DFD6453F2EC827A10073E133 /* .gitignore */ = {isa = PBXFileReference; lastKnownFileType = text; path = .gitignore; sourceTree = "<group>"; };
 		DFD74E2E2E423EA700613803 /* README.md */ = {isa = PBXFileReference; lastKnownFileType = net.daringfireball.markdown; path = README.md; sourceTree = "<group>"; };
 /* End PBXFileReference section */
@@ -91,7 +76,6 @@
 				DFD74E2E2E423EA700613803 /* README.md */,
 				DFE28EB62DCCF26300B28FE5 /* Frameworks */,
 				DFD48B012DC4D6E2005905C5 /* Products */,
-				DFD643A52EC787AB0073E133 /* Firebase */,
 			);
 			sourceTree = "<group>";
 		};
@@ -103,64 +87,6 @@
 			name = Products;
 			sourceTree = "<group>";
 		};
-		DFD643982EC787AB0073E133 /* auth */ = {
-			isa = PBXGroup;
-			children = (
-				DFD643952EC787AB0073E133 /* apple.ts */,
-				DFD643962EC787AB0073E133 /* github.ts */,
-				DFD643972EC787AB0073E133 /* google.ts */,
-			);
-			path = auth;
-			sourceTree = "<group>";
-		};
-		DFD6439B2EC787AB0073E133 /* fcm */ = {
-			isa = PBXGroup;
-			children = (
-				DFD643992EC787AB0073E133 /* notification.ts */,
-				DFD6439A2EC787AB0073E133 /* schedule.ts */,
-			);
-			path = fcm;
-			sourceTree = "<group>";
-		};
-		DFD6439D2EC787AB0073E133 /* user */ = {
-			isa = PBXGroup;
-			children = (
-				DFD6439C2EC787AB0073E133 /* delete.ts */,
-			);
-			path = user;
-			sourceTree = "<group>";
-		};
-		DFD6439F2EC787AB0073E133 /* src */ = {
-			isa = PBXGroup;
-			children = (
-				DFD643982EC787AB0073E133 /* auth */,
-				DFD6439B2EC787AB0073E133 /* fcm */,
-				DFD6439D2EC787AB0073E133 /* user */,
-				DFD6439E2EC787AB0073E133 /* index.ts */,
-			);
-			path = src;
-			sourceTree = "<group>";
-		};
-		DFD643A32EC787AB0073E133 /* functions */ = {
-			isa = PBXGroup;
-			children = (
-				DFD6439F2EC787AB0073E133 /* src */,
-				DFD643A02EC787AB0073E133 /* package.json */,
-				DFD643A12EC787AB0073E133 /* package-lock.json */,
-				DFD643A22EC787AB0073E133 /* tsconfig.json */,
-			);
-			path = functions;
-			sourceTree = "<group>";
-		};
-		DFD643A52EC787AB0073E133 /* Firebase */ = {
-			isa = PBXGroup;
-			children = (
-				DFD643A32EC787AB0073E133 /* functions */,
-				DFD643A42EC787AB0073E133 /* firebase.json */,
-			);
-			path = Firebase;
-			sourceTree = "<group>";
-		};
 		DFE28EB62DCCF26300B28FE5 /* Frameworks */ = {
 			isa = PBXGroup;
 			children = (
@@ -250,10 +176,6 @@
 			files = (
 				DFD645402EC827A10073E133 /* .gitignore in Resources */,
 				DFD74E2F2E423EA700613803 /* README.md in Resources */,
-				DFD643A72EC787AB0073E133 /* firebase.json in Resources */,
-				DFD643A92EC787AB0073E133 /* package.json in Resources */,
-				DFD643AC2EC787AB0073E133 /* tsconfig.json in Resources */,
-				DFD643AE2EC787AB0073E133 /* package-lock.json in Resources */,
 			);
 			runOnlyForDeploymentPostprocessing = 0;
 		};

DevLog/App/Assembler/AppLayerAssembler.swift

@@ -0,0 +1,21 @@
+//
+//  AppLayerAssembler.swift
+//  DevLog
+//
+//  Created by opfic on 3/19/26.
+//
+
+final class AppLayerAssembler: Assembler {
+    func assemble(_ container: any DIContainer) {
+        container.register(FCMTokenSyncHandler.self) {
+            FCMTokenSyncHandler(
+                repository: container.resolve(UserDataRepository.self)
+            )
+        }
+        container.register(UserTimeZoneSyncHandler.self) {
+            UserTimeZoneSyncHandler(
+                repository: container.resolve(UserDataRepository.self)
+            )
+        }
+    }
+}

DevLog/App/Assembler/Assembler.swift

@@ -11,9 +11,11 @@ protocol Assembler {
 
 final class AppAssembler: Assembler {
     private let assemblers: [Assembler] = [
+        PersistenceAssembler(),
         InfraAssembler(),
         DataAssembler(),
-        DomainAssembler()
+        DomainAssembler(),
+        AppLayerAssembler()
     ]
 
     func assemble(_ container: any DIContainer) {

DevLog/App/Assembler/DataAssembler.swift

@@ -34,8 +34,7 @@ final class DataAssembler: Assembler {
 
         container.register(AuthSessionRepository.self) {
             AuthSessionRepositoryImpl(
-                authService: container.resolve(AuthService.self),
-                userDefaultsStore: container.resolve(UserDefaultsStore.self)
+                authService: container.resolve(AuthService.self)
             )
         }
 

DevLog/App/Assembler/DomainAssembler.swift

@@ -66,6 +66,10 @@ private extension DomainAssembler {
         container.register(DeleteTodoUseCase.self) {
             DeleteTodoUseCaseImpl(container.resolve(TodoRepository.self))
         }
+
+        container.register(UndoDeleteTodoUseCase.self) {
+            UndoDeleteTodoUseCaseImpl(container.resolve(TodoRepository.self))
+        }
     }
 
     func registerUserDataUseCases(_ container: DIContainer) {
@@ -91,10 +95,18 @@ private extension DomainAssembler {
             DeletePushNotificationUseCaseImpl(container.resolve(PushNotificationRepository.self))
         }
 
+        container.register(UndoDeletePushNotificationUseCase.self) {
+            UndoDeletePushNotificationUseCaseImpl(container.resolve(PushNotificationRepository.self))
+        }
+
         container.register(FetchPushNotificationsUseCase.self) {
             FetchPushNotificationsUseCaseImpl(container.resolve(PushNotificationRepository.self))
         }
 
+        container.register(ObserveUnreadPushCountUseCase.self) {
+            ObserveUnreadPushCountUseCaseImpl(container.resolve(PushNotificationRepository.self))
+        }
+
         container.register(TogglePushNotificationReadUseCase.self) {
             TogglePushNotificationReadUseCaseImpl(container.resolve(PushNotificationRepository.self))
         }
@@ -112,6 +124,10 @@ private extension DomainAssembler {
         container.register(DeleteWebPageUseCase.self) {
             DeleteWebPageUseCaseImpl(container.resolve(WebPageRepository.self))
         }
+
+        container.register(UndoDeleteWebPageUseCase.self) {
+            UndoDeleteWebPageUseCaseImpl(container.resolve(WebPageRepository.self))
+        }
     }
 
     func registerUserPreferencesUseCases(_ container: DIContainer) {
@@ -123,14 +139,6 @@ private extension DomainAssembler {
             UpdateSystemThemeUseCaseImpl(container.resolve(UserPreferencesRepository.self))
         }
 
-        container.register(FetchFirstLaunchUseCase.self) {
-            FetchFirstLaunchUseCaseImpl(container.resolve(UserPreferencesRepository.self))
-        }
-
-        container.register(UpdateFirstLaunchUseCase.self) {
-            UpdateFirstLaunchUseCaseImpl(container.resolve(UserPreferencesRepository.self))
-        }
-
         container.register(FetchRecentSearchQueriesUseCase.self) {
             FetchRecentSearchQueriesUseCaseImpl(container.resolve(UserPreferencesRepository.self))
         }

DevLog/App/Assembler/InfraAssembler.swift

@@ -52,12 +52,5 @@ final class InfraAssembler: Assembler {
             WebPageMetadataService()
         }
 
-        container.register(UserDefaultsStore.self) {
-            UserDefaultsStore()
-        }
-
-        container.register(ThemeStore.self) {
-            ThemeStore()
-        }
     }
 }

DevLog/App/Assembler/PersistenceAssembler.swift

@@ -0,0 +1,18 @@
+//
+//  PersistenceAssembler.swift
+//  DevLog
+//
+//  Created by opfic on 3/15/26.
+//
+
+final class PersistenceAssembler: Assembler {
+    func assemble(_ container: any DIContainer) {
+        container.register(UserDefaultsStore.self) {
+            UserDefaultsStore()
+        }
+
+        container.register(ThemeStore.self) {
+            ThemeStore()
+        }
+    }
+}