[#85] PushNotification 구조체를 레이어에 맞게 개선한다 (#151)

* refactor: PushNotification 도메인화

* refacot: Presentation, UI 레이어 용 모델인 PushNotificationItem로 대체

* refactor: 데이터, 인프라 레이어 모델 대체

* refactor: 불필요 private init 제거

Author: opficdev

DevLog/Data/Mapper/PushNotificationMapping.swift

@@ -0,0 +1,53 @@
+//
+//  PushNotificationMapping.swift
+//  DevLog
+//
+//  Created by 최윤진 on 2/27/26.
+//
+
+import FirebaseFirestore
+
+extension PushNotificationResponse {
+    func toDomain() throws -> PushNotification {
+        guard let id = self.id else {
+            throw DataError.invalidData("PushNotificationResponse.id is nil")
+        }
+        guard let todoKind = TodoKind(rawValue: self.todoKind) else {
+            throw DataError.invalidData("PushNotificationResponse.todoKind is invalid: \(self.todoKind)")
+        }
+
+        return PushNotification(
+            id: id,
+            title: self.title,
+            body: self.body,
+            receivedAt: self.receivedAt.dateValue(),
+            isRead: self.isRead,
+            todoID: self.todoID,
+            todoKind: todoKind
+        )
+    }
+}
+
+extension PushNotificationCursorDTO {
+    func toDomain() -> PushNotificationCursor {
+        PushNotificationCursor(
+            receivedAt: self.receivedAt.dateValue(),
+            documentID: self.documentID
+        )
+    }
+
+    static func fromDomain(_ cursor: PushNotificationCursor) -> Self {
+        PushNotificationCursorDTO(
+            receivedAt: Timestamp(date: cursor.receivedAt),
+            documentID: cursor.documentID
+        )
+    }
+}
+
+extension PushNotificationPageResponse {
+    func toDomain() throws -> PushNotificationPage {
+        let items = try self.items.map { try $0.toDomain() }
+        let nextCursor = self.nextCursor?.toDomain()
+        return PushNotificationPage(items: items, nextCursor: nextCursor)
+    }
+}

DevLog/Data/Repository/PushNotificationRepositoryImpl.swift

@@ -36,33 +36,9 @@ final class PushNotificationRepositoryImpl: PushNotificationRepository {
         _ query: PushNotificationQuery,
         cursor: PushNotificationCursor?
     ) async throws -> PushNotificationPage {
-        let response = try await service.requestNotifications(query, cursor: cursor)
-
-        let items: [PushNotification] = response.items.compactMap { dto in
-            guard
-                let id = dto.id,
-                let todoKind = TodoKind(rawValue: dto.todoKind)
-            else { return nil }
-
-            return PushNotification(
-                id: id,
-                title: dto.title,
-                body: dto.body,
-                receivedAt: dto.receivedAt.dateValue(),
-                isRead: dto.isRead,
-                todoID: dto.todoID,
-                todoKind: todoKind
-            )
-        }
-
-        let nextCursor = response.nextCursor.map { cursor in
-            PushNotificationCursor(
-                receivedAt: cursor.receivedAt.dateValue(),
-                documentID: cursor.documentID
-            )
-        }
-
-        return PushNotificationPage(items: items, nextCursor: nextCursor)
+        let cursorDTO = cursor.map { PushNotificationCursorDTO.fromDomain($0) }
+        let response = try await service.requestNotifications(query, cursor: cursorDTO)
+        return try response.toDomain()
     }
 
     // 푸시 알림 기록 삭제

DevLog/Infra/DTO/PushNotification.swift …Log/Domain/Entity/PushNotification.swiftDevLog/Infra/DTO/PushNotification.swift renamed to DevLog/Domain/Entity/PushNotification.swift DevLog/Infra/DTO/PushNotification.swift renamed to DevLog/Domain/Entity/PushNotification.swift

@@ -7,7 +7,7 @@
 
 import Foundation
 
-struct PushNotification: Identifiable {
+struct PushNotification {
     let id: String
     let title: String
     let body: String

DevLog/Infra/DTO/PushNotificationCursorDTO.swift

@@ -0,0 +1,13 @@
+//
+//  PushNotificationCursorDTO.swift
+//  DevLog
+//
+//  Created by 최윤진 on 2/27/26.
+//
+
+import FirebaseFirestore
+
+struct PushNotificationCursorDTO {
+    let receivedAt: Timestamp
+    let documentID: String
+}

DevLog/Infra/DTO/PushNotificationCursorResponse.swift

@@ -7,5 +7,5 @@
 
 struct PushNotificationPageResponse {
     let items: [PushNotificationResponse]
-    let nextCursor: PushNotificationCursorResponse?
+    let nextCursor: PushNotificationCursorDTO?
 }

DevLog/Infra/DTO/PushNotificationPageResponse.swift

@@ -91,7 +91,7 @@ final class PushNotificationService {
     /// 푸시 알림 기록 요청
     func requestNotifications(
         _ query: PushNotificationQuery,
-        cursor: PushNotificationCursor?
+        cursor: PushNotificationCursorDTO?
     ) async throws -> PushNotificationPageResponse {
         guard let uid = Auth.auth().currentUser?.uid else { throw AuthError.notAuthenticated }
 
@@ -115,7 +115,7 @@ final class PushNotificationService {
 
         if let cursor {
             firestoreQuery = firestoreQuery.start(after: [
-                Timestamp(date: cursor.receivedAt),
+                cursor.receivedAt,
                 cursor.documentID
             ])
         }
@@ -128,12 +128,12 @@ final class PushNotificationService {
             try document.data(as: PushNotificationResponse.self)
         }
 
-        let nextCursor: PushNotificationCursorResponse? = snapshot.documents.last.map { document in
+        let nextCursor: PushNotificationCursorDTO? = snapshot.documents.last.map { document in
             guard let receivedAt = document.data()["receivedAt"] as? Timestamp else {
                 return nil
             }
 
-            return PushNotificationCursorResponse(
+            return PushNotificationCursorDTO(
                 receivedAt: receivedAt,
                 documentID: document.documentID
             )

DevLog/Infra/Service/PushNotificationService.swift

@@ -13,24 +13,10 @@ struct PinnedTodoItem: Identifiable, Hashable {
     let dueDate: Date?
     let kind: TodoKind
 
-    private init(
-        id: String,
-        title: String,
-        dueDate: Date?,
-        kind: TodoKind
-    ) {
-        self.id = id
-        self.title = title
-        self.dueDate = dueDate
-        self.kind = kind
-    }
-
     init(from todo: Todo) {
-        self.init(
-            id: todo.id,
-            title: todo.title,
-            dueDate: todo.dueDate,
-            kind: todo.kind
-        )
+        self.id = todo.id
+        self.title = todo.title
+        self.dueDate = todo.dueDate
+        self.kind = todo.kind
     }
 }

DevLog/Presentation/Structure/PinnedTodoItem.swift

@@ -0,0 +1,28 @@
+//
+//  PushNotificationItem.swift
+//  DevLog
+//
+//  Created by 최윤진 on 2/27/26.
+//
+
+import Foundation
+
+struct PushNotificationItem: Identifiable, Hashable {
+    let id: String
+    let title: String
+    let body: String
+    let receivedAt: Date
+    var isRead: Bool
+    let todoID: String
+    let todoKind: TodoKind
+
+    init(from notification: PushNotification) {
+        self.id = notification.id
+        self.title = notification.title
+        self.body = notification.body
+        self.receivedAt = notification.receivedAt
+        self.isRead = notification.isRead
+        self.todoID = notification.todoID
+        self.todoKind = notification.todoKind
+    }
+}

DevLog/Presentation/Structure/PushNotificationItem.swift

@@ -13,24 +13,10 @@ struct TodoListItem: Identifiable, Hashable {
     let tags: [String]
     let isPinned: Bool
 
-    private init(
-        id: String,
-        title: String,
-        tags: [String],
-        isPinned: Bool
-    ) {
-        self.id = id
-        self.title = title
-        self.tags = tags
-        self.isPinned = isPinned
-    }
-
     init(from todo: Todo) {
-        self.init(
-            id: todo.id,
-            title: todo.title,
-            tags: todo.tags,
-            isPinned: todo.isPinned
-        )
+        self.id = todo.id
+        self.title = todo.title
+        self.tags = todo.tags
+        self.isPinned = todo.isPinned
     }
 }