[#249] 개인정보 처리방침을 탭하면 빈 링크로 이동하는 이슈를 해결한다

[opficdev]

• closed 개인정보 처리방침을 탭하면 빈 링크로 이동하는 이슈를 해결한다 #249

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

이 PR은 설정 화면에서 개인정보 처리방침 링크가 올바르게 작동하지 않던 문제를 해결하고, 앱 버전 및 스토어 관련 URL 정보를 관리하는 방식을 개선합니다. 뷰 모델의 데이터 접근 방식을 재구성하여 코드의 가독성과 유지보수성을 높였습니다.

Highlights

• 뷰 모델 구조 개선: SettingViewModel 내에서 appVersion과 policyURL 속성을 State 구조체 밖으로 이동시켜 직접 접근하도록 변경했습니다. 또한, appstoreUrl 속성을 추가했습니다.
• 개인정보 처리방침 링크 수정: SettingView에서 개인정보 처리방침 링크를 탭했을 때 빈 링크로 이동하던 문제를 해결했습니다. 이제 policyURL이 유효한 경우에만 링크가 활성화됩니다.
• 베타 테스트 참여 로직 간소화: "베타 테스트 참여" 버튼의 동작 로직을 간소화하여, SettingViewModel에 추가된 appstoreUrl을 직접 사용하여 앱스토어 링크를 엽니다.

Changelog

• DevLog/Presentation/ViewModel/SettingViewModel.swift
  • State 구조체에서 appVersion과 policyURL 속성을 제거했습니다.
  • SettingViewModel 클래스에 appVersion, appstoreUrl, policyURL 속성을 직접 추가했습니다.
• DevLog/UI/Setting/SettingView.swift
  • appVersion과 policyURL에 접근하는 방식을 viewModel.state.appVersion에서 viewModel.appVersion으로 변경했습니다.
  • 개인정보 처리방침 링크를 생성할 때 URL 유효성 검사를 추가했습니다.
  • "베타 테스트 참여" 버튼의 액션 로직을 viewModel.appstoreUrl을 사용하여 앱스토어 링크를 직접 열도록 간소화했습니다.

Activity

• 이 PR은 이슈 #249를 해결했습니다.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This PR addresses the issue of an empty privacy policy link and improves related code structure. Specifically, it enhances architecture by moving static configuration values like appVersion and policyURL out of the State struct in SettingViewModel, and increases stability by replacing force unwrapping with safe optional binding when generating the privacy policy URL in SettingView. A security review of DevLog/Presentation/ViewModel/SettingViewModel.swift, DevLog/UI/Setting/SettingView.swift, and DevLog/Resource/Info.plist found no vulnerabilities. Overall, these are good modifications that improve code stability and maintainability, with one suggestion included.