Skip to content

[#327] TodoListView에서 스크롤을 하면 ui가 멈추는 현상을 해결한다 #328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
opficdev merged 2 commits into from
Mar 28, 2026
Merged

[#327] TodoListView에서 스크롤을 하면 ui가 멈추는 현상을 해결한다 #328

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6e8b7a1
fix: rounded를 통해 과도한 수치 변화를 줄인다
opficdev Mar 28, 2026
bbf26a8
style: iOS 17 스타일 반영
opficdev Mar 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions DevLog/UI/Home/TodoListView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,10 +303,10 @@ struct TodoListView: View {
GeometryReader { geometry in
Color.clear
.onAppear {
headerHeight = geometry.size.height + 1
headerHeight = geometry.size.height.rounded()
}
.onChange(of: geometry.size.height) { _, height in
headerHeight = height + 1
headerHeight = height.rounded()
}
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot Mar 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

iOS 17부터 onChange 수정자에 initial 파라미터가 추가되어 onAppear와 onChange를 하나로 합칠 수 있습니다. 코드를 더 간결하게 만들 수 있으니 적용해보시는 것을 추천합니다.

Suggested change
.onAppear {
headerHeight = geometry.size.height + 1
headerHeight = geometry.size.height.rounded()
}
.onChange(of: geometry.size.height) { _, height in
headerHeight = height + 1
headerHeight = height.rounded()
}
.onChange(of: geometry.size.height, initial: true) { _, height in
headerHeight = height.rounded()
}

}
}
Expand Down