Skip to content

[#360] 홈뷰의 웹페이지 섹션의 이미지 크기를 수정한다 #361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
opficdev merged 1 commit into from
Apr 5, 2026
Merged

[#360] 홈뷰의 웹페이지 섹션의 이미지 크기를 수정한다 #361

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion DevLog/UI/Common/Component/WebItemRow.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ struct WebItemRow: View {
var body: some View {
HStack {
thumbnail
.frame(width: sceneWidth / 10, height: sceneWidth / 10)
.frame(width: sceneWidth * 0.08, height: sceneWidth * 0.08)
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot Apr 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

화면 너비(sceneWidth)에 비례하여 이미지 크기를 설정하면 기기 해상도에 따라 UI 일관성이 깨질 수 있습니다. 특히 현재 sceneWidth 구현은 기기의 전체 너비를 반환하므로, iPad의 Split View 등 멀티태스킹 환경에서 이미지가 의도보다 크게 표시될 수 있습니다. 가급적 고정된 크기(Point)를 사용하거나, 0.08과 같은 매직 넘버를 의미 있는 상수로 정의하여 관리하는 것을 권장합니다.

.clipShape(RoundedRectangle(cornerRadius: 10))

VStack(alignment: .leading) {
Expand Down