Conversation
Contributor
There was a problem hiding this comment.
Code Review
이번 풀 리퀘스트는 PR 템플릿 추가, 로딩 지연 시간 조정 및 주요 ViewModel들의 로딩 모드를 .delayed로 변경하여 사용자 경험을 개선합니다. 특히 SearchViewModel과 TodoListViewModel에서 검색 태스크 관리 로직을 강화하고 LoadingState를 통합했습니다. 리뷰에서는 검색 작업 취소 시 cancelSearch()와 defer 블록에서 endLoading이 중복 호출되어 로딩 카운트가 비정상적으로 감소할 수 있는 문제가 지적되었으며, 작업 취소 여부를 확인한 후 로딩을 종료하도록 개선이 필요합니다.
| defer { send(.setLoading(false)) } | ||
| defer { | ||
| self.searchTasks[.request] = nil | ||
| self.endLoading(.immediate) |
Contributor
There was a problem hiding this comment.
| defer { endLoading(.immediate) } | ||
| defer { | ||
| self.searchTasks[.request] = nil | ||
| self.endLoading(.immediate) |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 연관된 이슈
📝 작업 내용
📌 요약
🔍 상세