mvc: deprecate htmlspecialchars() use#10041
Open
Greelan wants to merge 3 commits into
Open
Conversation
fichtner
reviewed
Mar 26, 2026
| const aliasMetadataList = row["alias_meta_" + column.id] || []; | ||
|
|
||
| const renderedItems = aliasMetadataList.map(aliasInfo => { | ||
| const safeText = $('<span>').text(aliasInfo.value || '').html(); |
Member
There was a problem hiding this comment.
In volt we have {{ var | safe }} btw...
Member
There was a problem hiding this comment.
(it doesn't account for API data returns, I know but I wanted to mention it)
Contributor
Author
There was a problem hiding this comment.
Right, that's why I was happy to rely on {{ var }} where relevant
Contributor
Author
There was a problem hiding this comment.
Actually, my bad, I'd understood that volt auto-escaped. I've now added explicit |safe attributes
Member
|
Thanks, I'll look at this in two weeks. Busy schedule at the moment. If I don't please ping me again. |
Contributor
Author
|
@fichtner ping as requested |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempt at addressing #7337