Added NAS-IP-Address attribute to radius access server calls#10089
Added NAS-IP-Address attribute to radius access server calls#10089metmayhem wants to merge 3 commits into
Conversation
Changed NAS-Port-Type to virtual for radius access server calls
AdSchellevis
left a comment
AdSchellevis
left a comment
There was a problem hiding this comment.
@metmayhem it needs some modifications to ease future maintenance, but adding the field shouldn't be an issue.
…in PR comment Made RADIUS_NAS_PORT_TYPE hard-coded to RADIUS_VIRTUAL as suggested in PR comment Added dropdown of available interface IPs for NAS-IP-Address
metmayhem
left a comment
metmayhem
left a comment
There was a problem hiding this comment.
Requested changes have been made. Also changed NAS IP Address field to a dropdown that contains all available interface IPs.
| */ | ||
|
|
||
| namespace OPNsense\Auth; | ||
| require_once("interfaces.inc"); |
There was a problem hiding this comment.
it's not allowed to insert legacy files inside new MVC based code, but I also don't think we need it to be honest. If we just validate the input for validity, we don't have to select a static list of addresses (and make sure the user can also use virtual addresses as well).
I'll have a look at the code and see if I can fix the concerns.
|
@metmayhem can you try 95483e5 ? It should implement what you need. |
|
It looks to be working. I did kind of like my addition of the dropdown (prevents human error during setup), but this gets the job done. Thanks |
2 participants
Added NAS-IP-Address attribute to radius access server calls
Changed NAS-Port-Type to virtual for radius access server calls
No open issues I could find regarding this, but I needed NAS-IP-Address to be set for Microsoft NPS to work. I also found that the NAS-Port-Type was hard coded to RADIUS_ETHERNET which didn't work with NPS either. I changed it to be hard coded RADIUS_VIRTUAL for access servers and kept the default of RADIUS_ETHERNET for everything else.