MVC: blank UI space

[sopex]

Important notices

Before you submit a pull request, we ask you kindly to acknowledge the following:

• I have read the contributing guidelines at https://github.com/opnsense/core/blob/master/CONTRIBUTING.md
• I opened an issue first for non-trivial changes and linked it below.
• AI tools were used to create at least part of the code submitted herewith.

Closes: #10150

[fichtner]

Screenshots please, hard to gauge from here

[sopex]

See the ones in the issue for the before

[sopex]

@swhite2 If you have a moment here too :) Its just the white line above the copyright notice, nothing major.

[swhite2]

To be honest I'm unsure where the padding was relevant to begin with or how this would affect custom themes. Maybe @AdSchellevis has an idea?

[AdSchellevis]

Could have been a miscalculation in 49f7da2

The container height should be 100% - 55px if I'm not mistaken, currently its:

height: calc(100% - 62px);

You likely don't want to extend it to 100% as stuff in the container might fall behind the footer in that case.

[sopex]

Could have been a miscalculation in 49f7da2

The container height should be 100% - 55px if I'm not mistaken, currently its:

height: calc(100% - 62px);

You likely don't want to extend it to 100% as stuff in the container might fall behind the footer in that case.

It currently doesn't seem to cause any such issues, I have been using it since mid-April, but if 55 is calculated to work in all screens, even better.

[sopex]

-55px seems to also fix the issue, so let's go with that to leave some margin as @AdSchellevis suggested

[fichtner]

this is very peculiar as it wasn't defined anywhere but still being "used":

% git grep content-box-main
src/opnsense/mvc/app/views/OPNsense/CaptivePortal/vouchers.volt:    <div class="content-box-main">
src/opnsense/mvc/app/views/OPNsense/Diagnostics/arp.volt:    <div class="content-box-main">
src/opnsense/mvc/app/views/OPNsense/Diagnostics/log.volt:    <div class="content-box-main">
src/opnsense/mvc/app/views/OPNsense/Diagnostics/ndp.volt:    <div class="content-box-main">
src/opnsense/mvc/app/views/OPNsense/Diagnostics/routes.volt:    <div class="content-box-main">
src/opnsense/mvc/app/views/OPNsense/Diagnostics/systemactivity.volt:    <div class="content-box-main">
src/opnsense/mvc/app/views/OPNsense/TrafficShaper/statistics.volt:        <div class="content-box-main">
src/opnsense/mvc/app/views/OPNsense/Unbound/stats.volt:    <div class="content-box-main">
src/www/index.php:                <div class="content-box-main" style="padding-bottom:0px;">

[sopex]

Indeed, it was deleted on 0e999cc

Keep or delete?

[sopex]

@fichtner Any suggestions here?