Update to EISOP 3.42-eisop4 from 3.42-eisop3

.github/workflows/main.yml

@@ -50,6 +50,7 @@ jobs:
       - name: Install Python dependencies
         run: |
           python3 -m pip install --upgrade pip
+          pip install --upgrade setuptools wheel
           if [ -f requirements.txt ]; then pip install -r requirements.txt; fi
       - name: Spotless Check
         if: matrix.jdk == 11 || matrix.jdk == 17

src/checkers/inference/InferenceAnnotatedTypeFactory.java

@@ -512,9 +512,8 @@ protected void applyInferredAnnotations(
      * This is the same as the super method, but we do not want to use defaults or typeAnnotator.
      */
     @Override
-    protected void addComputedTypeAnnotations(
-            Tree tree, AnnotatedTypeMirror type, boolean iUseFlow) {
-        assert root != null
+    protected void addComputedTypeAnnotations(Tree tree, AnnotatedTypeMirror type) {
+        assert getRoot() != null
                 : "GenericAnnotatedTypeFactory.annotateImplicit: "
                         + " root needs to be set when used on trees; factory: "
                         + this.getClass();
@@ -527,7 +526,7 @@ protected void addComputedTypeAnnotations(
         // typeAnnotator.visit(type, null);
         defaults.annotate(tree, type);
 
-        if (iUseFlow) {
+        if (getUseFlow()) {
             CFValue as = getInferredValueFor(tree);
             if (as != null) {
                 applyInferredAnnotations(type, as);

src/checkers/inference/util/defaults/InferenceQualifierDefaults.java

@@ -74,9 +74,8 @@ public void applyDefault(Default def) {
         }
 
         @Override
-        protected boolean shouldBeAnnotated(AnnotatedTypeMirror type, boolean applyToTypeVar) {
-            return super.shouldBeAnnotated(type, applyToTypeVar)
-                    && !type.hasAnnotation(VarAnnot.class);
+        protected boolean shouldBeAnnotated(AnnotatedTypeMirror type) {
+            return super.shouldBeAnnotated(type) && !type.hasAnnotation(VarAnnot.class);
         }
     }
 }

src/sparta/checkers/SimpleFlowAnnotatedTypeFactory.java

@@ -233,11 +233,10 @@ protected void addCheckedCodeDefaults(QualifierDefaults defaults) {
     }
 
     @Override
-    protected void addComputedTypeAnnotations(
-            Tree tree, AnnotatedTypeMirror type, boolean useFlow) {
+    protected void addComputedTypeAnnotations(Tree tree, AnnotatedTypeMirror type) {
         Element element = TreeUtils.elementFromTree(tree);
         handleDefaulting(element, type);
-        super.addComputedTypeAnnotations(tree, type, useFlow);
+        super.addComputedTypeAnnotations(tree, type);
     }
 
     @Override