Skip to content

Commit 148f9eb

Browse files
srishanmopsiff
authored andcommitted
drm/amdgpu: Fix function header names in amdgpu_connectors.c
commit 38ab33d upstream. Align the function headers for `amdgpu_max_hdmi_pixel_clock` and `amdgpu_connector_dvi_mode_valid` with the function implementations so they match the expected kdoc style. Fixes the below: drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c:1199: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst * Returns the maximum supported HDMI (TMDS) pixel clock in KHz. drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c:1212: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst * Validates the given display mode on DVI and HDMI connectors. Fixes: 585b2f6 ("drm/amdgpu: Respect max pixel clock for HDMI and DVI-D (v2)") Cc: Christian König <christian.koenig@amd.com> Cc: Alex Deucher <alexander.deucher@amd.com> Signed-off-by: Srinivasan Shanmugam <srinivasan.shanmugam@amd.com> Reviewed-by: Alex Deucher <alexander.deucher@amd.com> Signed-off-by: Alex Deucher <alexander.deucher@amd.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> (cherry picked from commit f10a6f51984b9b458beadae57a28e80c9fb31554) Signed-off-by: Wentao Guan <guanwentao@uniontech.com>
1 parent b2fa7a7 commit 148f9eb

1 file changed

Lines changed: 12 additions & 3 deletions

File tree

drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1229,7 +1229,10 @@ static void amdgpu_connector_dvi_force(struct drm_connector *connector)
12291229
}
12301230

12311231
/**
1232-
* Returns the maximum supported HDMI (TMDS) pixel clock in KHz.
1232+
* amdgpu_max_hdmi_pixel_clock - Return max supported HDMI (TMDS) pixel clock
1233+
* @adev: pointer to amdgpu_device
1234+
*
1235+
* Return: maximum supported HDMI (TMDS) pixel clock in KHz.
12331236
*/
12341237
static int amdgpu_max_hdmi_pixel_clock(const struct amdgpu_device *adev)
12351238
{
@@ -1242,8 +1245,14 @@ static int amdgpu_max_hdmi_pixel_clock(const struct amdgpu_device *adev)
12421245
}
12431246

12441247
/**
1245-
* Validates the given display mode on DVI and HDMI connectors,
1246-
* including analog signals on DVI-I.
1248+
* amdgpu_connector_dvi_mode_valid - Validate a mode on DVI/HDMI connectors
1249+
* @connector: DRM connector to validate the mode on
1250+
* @mode: display mode to validate
1251+
*
1252+
* Validate the given display mode on DVI and HDMI connectors, including
1253+
* analog signals on DVI-I.
1254+
*
1255+
* Return: drm_mode_status indicating whether the mode is valid.
12471256
*/
12481257
static enum drm_mode_status amdgpu_connector_dvi_mode_valid(struct drm_connector *connector,
12491258
struct drm_display_mode *mode)

0 commit comments

Comments
 (0)