Skip to content

Commit 564f143

Browse files
jhovoldopsiff
authored andcommitted
regulator: rk808: fix OF node reference imbalance
commit 65290b24d8a5f0b8cd065201e653db824c4a4da6 upstream. The driver reuses the OF node of the parent multi-function device but fails to take another reference to balance the one dropped by the platform bus code when unbinding the MFD and deregistering the child devices. Fix this by using the intended helper for reusing OF nodes. Fixes: 647e573 ("regulator: rk808: reduce 'struct rk808' usage") Cc: stable@vger.kernel.org # 6.2 Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.com> Reviewed-by: Douglas Anderson <dianders@chromium.org> Signed-off-by: Johan Hovold <johan@kernel.org> Link: https://patch.msgid.link/20260408073055.5183-3-johan@kernel.org Signed-off-by: Mark Brown <broonie@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> (cherry picked from commit da769e8f8e3463953cb134b7c24ba0652cd922eb) Signed-off-by: Wentao Guan <guanwentao@uniontech.com>
1 parent 6ee4966 commit 564f143

1 file changed

Lines changed: 1 addition & 2 deletions

File tree

drivers/regulator/rk808-regulator.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1674,8 +1674,7 @@ static int rk808_regulator_probe(struct platform_device *pdev)
16741674
struct regmap *regmap;
16751675
int ret, i, nregulators;
16761676

1677-
pdev->dev.of_node = pdev->dev.parent->of_node;
1678-
pdev->dev.of_node_reused = true;
1677+
device_set_of_node_from_dev(&pdev->dev, pdev->dev.parent);
16791678

16801679
regmap = dev_get_regmap(pdev->dev.parent, NULL);
16811680
if (!regmap)

0 commit comments

Comments
 (0)