Skip to content

Commit 8d62123

Browse files
nizhen-topsiff
authored andcommitted
i40e: Fix potential invalid access when MAC list is empty
[ Upstream commit a556f06 ] list_first_entry() never returns NULL - if the list is empty, it still returns a pointer to an invalid object, leading to potential invalid memory access when dereferenced. Fix this by using list_first_entry_or_null instead of list_first_entry. Fixes: e3219ce ("i40e: Add support for client interface for IWARP driver") Signed-off-by: Zhen Ni <zhen.ni@easystack.cn> Reviewed-by: Paul Menzel <pmenzel@molgen.mpg.de> Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com> Signed-off-by: Sasha Levin <sashal@kernel.org> (cherry picked from commit fb216d980fae6561c7c70af8ef826faf059c6515)
1 parent 08fadf3 commit 8d62123

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

drivers/net/ethernet/intel/i40e/i40e_client.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -361,8 +361,8 @@ static void i40e_client_add_instance(struct i40e_pf *pf)
361361
if (i40e_client_get_params(vsi, &cdev->lan_info.params))
362362
goto free_cdev;
363363

364-
mac = list_first_entry(&cdev->lan_info.netdev->dev_addrs.list,
365-
struct netdev_hw_addr, list);
364+
mac = list_first_entry_or_null(&cdev->lan_info.netdev->dev_addrs.list,
365+
struct netdev_hw_addr, list);
366366
if (mac)
367367
ether_addr_copy(cdev->lan_info.lanmac, mac->addr);
368368
else

0 commit comments

Comments
 (0)