Skip to content

Commit eaf249b

Browse files
bp3tk0vopsiff
authored andcommitted
x86/microcode/AMD: Fix a -Wsometimes-uninitialized clang false positive
commit 5343558 upstream. Initialize equiv_id in order to shut up: arch/x86/kernel/cpu/microcode/amd.c:714:6: warning: variable 'equiv_id' is \ used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized] if (x86_family(bsp_cpuid_1_eax) < 0x17) { ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ because clang doesn't do interprocedural analysis for warnings to see that this variable won't be used uninitialized. Fixes: 94838d2 ("x86/microcode/AMD: Use the family,model,stepping encoded in the patch ID") Reported-by: kernel test robot <lkp@intel.com> Closes: https://lore.kernel.org/oe-kbuild-all/202407291815.gJBST0P3-lkp@intel.com/ Signed-off-by: Borislav Petkov (AMD) <bp@alien8.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> (cherry picked from commit 98a4462)
1 parent be58648 commit eaf249b

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

  • arch/x86/kernel/cpu/microcode

arch/x86/kernel/cpu/microcode/amd.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -645,7 +645,7 @@ static void free_cache(void)
645645
static struct ucode_patch *find_patch(unsigned int cpu)
646646
{
647647
struct ucode_cpu_info *uci = ucode_cpu_info + cpu;
648-
u16 equiv_id;
648+
u16 equiv_id = 0;
649649

650650

651651
equiv_id = find_equiv_id(&equiv_table, uci->cpu_sig.sig);

0 commit comments

Comments
 (0)