Skip to content

Commit fab94bf

Browse files
Russell King (Oracle)opsiff
authored andcommitted
net: stmmac: avoid shadowing global buf_sz
[ Upstream commit 876cfb2 ] stmmac_rx() declares a local variable named "buf_sz" but there is also a global variable for a module parameter which is called the same. To avoid confusion, rename the local variable. Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk> Reviewed-by: Furong Xu <0x1207@gmail.com> Link: https://patch.msgid.link/E1tpswi-005U6C-Py@rmk-PC.armlinux.org.uk Signed-off-by: Jakub Kicinski <kuba@kernel.org> Stable-dep-of: 0bb05e6adfa9 ("net: stmmac: Prevent NULL deref when RX memory exhausted") Signed-off-by: Sasha Levin <sashal@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> (cherry picked from commit 6a74af77eba57ddad6cdd43938adb0928e13ec2c) Signed-off-by: Wentao Guan <guanwentao@uniontech.com>
1 parent a7b33b4 commit fab94bf

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

drivers/net/ethernet/stmicro/stmmac/stmmac_main.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5298,10 +5298,10 @@ static int stmmac_rx(struct stmmac_priv *priv, int limit, u32 queue)
52985298
struct sk_buff *skb = NULL;
52995299
struct stmmac_xdp_buff ctx;
53005300
int xdp_status = 0;
5301-
int buf_sz;
5301+
int bufsz;
53025302

53035303
dma_dir = page_pool_get_dma_dir(rx_q->page_pool);
5304-
buf_sz = DIV_ROUND_UP(priv->dma_conf.dma_buf_sz, PAGE_SIZE) * PAGE_SIZE;
5304+
bufsz = DIV_ROUND_UP(priv->dma_conf.dma_buf_sz, PAGE_SIZE) * PAGE_SIZE;
53055305
limit = min(priv->dma_conf.dma_rx_size - 1, (unsigned int)limit);
53065306

53075307
if (netif_msg_rx_status(priv)) {
@@ -5414,7 +5414,7 @@ static int stmmac_rx(struct stmmac_priv *priv, int limit, u32 queue)
54145414
net_prefetch(page_address(buf->page) +
54155415
buf->page_offset);
54165416

5417-
xdp_init_buff(&ctx.xdp, buf_sz, &rx_q->xdp_rxq);
5417+
xdp_init_buff(&ctx.xdp, bufsz, &rx_q->xdp_rxq);
54185418
xdp_prepare_buff(&ctx.xdp, page_address(buf->page),
54195419
buf->page_offset, buf1_len, true);
54205420

0 commit comments

Comments
 (0)