infrahubctl check to find and filter the same as PC checks#446
infrahubctl check to find and filter the same as PC checks#446FragmentedPacket wants to merge 4 commits into
infrahubctl check to find and filter the same as PC checks#446Conversation
…n't change and potential issues arise if the identifier is only valid on the specific object and not the 'CoreGroup'.
Deploying infrahub-sdk-python with
|
| Latest commit: |
1159059
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://9c426057.infrahub-sdk-python.pages.dev |
| Branch Preview URL: | https://may-202506-445-check-attribu.infrahub-sdk-python.pages.dev |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## stable #446 +/- ##
==========================================
+ Coverage 75.57% 75.59% +0.01%
==========================================
Files 100 100
Lines 8750 8748 -2
Branches 1704 1703 -1
==========================================
Hits 6613 6613
+ Misses 1661 1659 -2
Partials 476 476
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
| # TODO: Does this support multiple parameters and we need make identifiers a dict to iterate over on L166-168? | ||
| for param_key, param_value in check_module.definition.parameters.items(): | ||
| identifier = param_key | ||
| identifier_attribute = param_value.split("__")[0] |
There was a problem hiding this comment.
I think this might be fine as it resolves a previous error. But I'm not sure these params really work today if you have more than one. This is something that we should address. It's also problematic with regards to a query that might look like this instead:
query TagsQuery($tag_name: String!) {
BuiltinTag(name__value: $tag_name) {
edges {
node {
description {
value
}
}
}
}
}I.e. it's a valid check but the name is missing and as such will be reported as null.
Have you tried to run this same check and code within the pipeline in Infrahub as well? I think we might need to fix something there too.
There was a problem hiding this comment.
Hey @ogenstad, I ran the same check from the issue in the pipeline and it succeeds with no issue.
If I update the GraphQL query to above, the check fails but that is due to the code within the check.
|
Closing due to a larger effort required: opsmill/infrahub#7188 |
2 participants
Fixes #445
parametersdefined in acheck_definitionand set the parameters into the GraphQL query properlyidentifierto a dictionary with the to be properly passed into the GraphQL to support multiple parameters.