fix lint and mypy errors after rebase onto main

- align regenerated protocols.py IpamIPPrefix annotations with SDK v1.22.0
- add targeted type ignores for stricter SDK relationship/pool typing
- apply rumdl markdown formatting to overlay docs flagged by new CI lint

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

Author: dgarros

CONTEXT.md

@@ -10,12 +10,12 @@ they are used consistently in code, schema, and conversation.
 ### Design model
 
 **Design object**:
-An object that records *intent* — what infrastructure should look like — and persists in Infrahub
+An object that records _intent_ — what infrastructure should look like — and persists in Infrahub
 independent of whether Generators have run (e.g. a Fabric, Pod, Rack, or Tenant).
 _Avoid_: input, spec, template (a "device template" is a distinct supporting object).
 
 **Implementation object**:
-An object a Generator *produces* from design intent — devices, interfaces, links, IP allocations, VNI/RT
+An object a Generator _produces_ from design intent — devices, interfaces, links, IP allocations, VNI/RT
 allocations, materialized relationships.
 _Avoid_: output, artifact (an "artifact" is specifically a rendered file like a startup config or cabling CSV).
 

generators/generate_fabric.py

@@ -87,7 +87,7 @@ async def configure_overlay(self) -> None:
 
         if fabric.overlay_asn.value is None:
             asn_pool = await self.client.get(kind=CoreNumberPool, name__value=ASN_POOL_NAME)
-            fabric.overlay_asn.value = asn_pool  # number pool -> server-side from_pool allocation
+            fabric.overlay_asn.value = asn_pool  # type: ignore[assignment]  # number pool -> server-side from_pool allocation
             if not fabric.routing_design.value:
                 fabric.routing_design.value = DEFAULT_ROUTING_DESIGN
             await fabric.save(allow_upsert=True)

generators/generate_tenant.py

@@ -125,17 +125,17 @@ async def configure_vrf(self, vrf_node: TenantGeneratorQueryVrfNode, overlay_asn
         vrf = await self.client.get(kind=NetworkVrf, id=vrf_node.id)
         changed = False
         if vrf.l3vni.value is None:
-            vrf.l3vni.value = await self.client.get(kind=CoreNumberPool, name__value=L3VNI_POOL)
+            vrf.l3vni.value = await self.client.get(kind=CoreNumberPool, name__value=L3VNI_POOL)  # type: ignore[assignment]
             changed = True
         if vrf.l3_vlan_id.value is None:
-            vrf.l3_vlan_id.value = await self.client.get(kind=CoreNumberPool, name__value=VLAN_L3_POOL)
+            vrf.l3_vlan_id.value = await self.client.get(kind=CoreNumberPool, name__value=VLAN_L3_POOL)  # type: ignore[assignment]
             changed = True
         if changed:
             await vrf.save(allow_upsert=True, update_group_context=False)
             # FIX: pool-allocated values are not readable on the returned node; re-fetch to read them
             vrf = await self.client.get(kind=NetworkVrf, id=vrf_node.id)
 
-        rt = route_target(overlay_asn, vrf.l3vni.value)
+        rt = route_target(overlay_asn, vrf.l3vni.value)  # type: ignore[arg-type]
         if vrf.route_target.value != rt:
             vrf.route_target.value = rt
             await vrf.save(allow_upsert=True, update_group_context=False)
@@ -145,17 +145,17 @@ async def configure_segment(self, segment_node: TenantGeneratorQuerySegmentNode,
         segment = await self.client.get(kind=NetworkSegment, id=segment_node.id)
         changed = False
         if segment.vlan_id.value is None:
-            segment.vlan_id.value = await self.client.get(kind=CoreNumberPool, name__value=VLAN_L2_POOL)
+            segment.vlan_id.value = await self.client.get(kind=CoreNumberPool, name__value=VLAN_L2_POOL)  # type: ignore[assignment]
             changed = True
         if segment.l2vni.value is None:
-            segment.l2vni.value = await self.client.get(kind=CoreNumberPool, name__value=L2VNI_POOL)
+            segment.l2vni.value = await self.client.get(kind=CoreNumberPool, name__value=L2VNI_POOL)  # type: ignore[assignment]
             changed = True
         if changed:
             await segment.save(allow_upsert=True, update_group_context=False)
             # FIX: pool-allocated values are not readable on the returned node; re-fetch to read them
             segment = await self.client.get(kind=NetworkSegment, id=segment_node.id)
 
-        rt = route_target(overlay_asn, segment.l2vni.value)
+        rt = route_target(overlay_asn, segment.l2vni.value)  # type: ignore[arg-type]
         if segment.route_target.value != rt:
             segment.route_target.value = rt
             await segment.save(allow_upsert=True, update_group_context=False)
@@ -175,13 +175,13 @@ async def allocate_subnet_and_gateway(self, segment: NetworkSegment) -> None:
             data={"role": "tenant_subnet"},
         )
 
-        network = subnet.prefix.value
+        network = subnet.prefix.value  # type: ignore[union-attr]
         gateway_ip = list(network.hosts())[GATEWAY_HOST_INDEX - 1]
         gateway = await self.client.create(kind="IpamIPAddress", address=f"{gateway_ip}/{network.prefixlen}")
         await gateway.save(allow_upsert=True, update_group_context=False)
 
-        segment.subnet = subnet
-        segment.gateway = gateway
+        segment.subnet = subnet  # type: ignore[assignment]
+        segment.gateway = gateway  # type: ignore[assignment]
         await segment.save(allow_upsert=True, update_group_context=False)
         self.logger.info(f"Allocated subnet {network} (gw {gateway_ip}) for segment {segment.name.value}")
 

specs/001-evpn-overlay/contracts/config-artifact.md

@@ -72,6 +72,7 @@ router bgp <device.asn>
 ```
 
 ## Invariants
+
 - A device with no materialized `segments` renders **no** NVE/VLAN/VRF/SVI (guarantees spine/super-spine
   carry no tenant state — FR-007, SC-006).
 - An L2-only segment (no `gateway`) renders its `vlan`/`vn-segment`/NVE `member vni` but **no** anycast SVI

specs/001-evpn-overlay/contracts/graphql-queries.md

@@ -60,6 +60,7 @@ NetworkDevice(hostname__value: $name)
 ```
 
 **Notes**:
+
 - iBGP peers = the directly-connected neighbors surfaced via `interfaces → link → endpoints → … on
   NetworkInterface → device` (filter out self). RR-client toward lower tiers is derived in the template.
 - Spine/super-spine renders have no `segments` (none materialized) → no NVE/VRF/SVI.

specs/001-evpn-overlay/contracts/infrahub-registration.md

@@ -6,12 +6,14 @@ generator/query/trigger entries already in `.infrahub.yml` and `objects/20_trigg
 ## `.infrahub.yml` additions
 
 **queries** — add:
+
 - `generate_tenant` → `generators/generate_tenant.gql`
 
 (The existing `network_device_startup_config` query entry is unchanged; its `.gql` file content is expanded
 per the GraphQL contract.)
 
 **generator_definitions** — add:
+
 ```text
 - name: generate-tenant
   file_path: generators/generate_tenant.py        # class OverlayGenerator
@@ -26,16 +28,20 @@ per the GraphQL contract.)
 config. No new artifact is introduced.
 
 ## Groups (`objects/01_groups.yml`)
+
 - Add a `tenants` `CoreStandardGroup` (parallels the existing halls/racks/fabrics/pods/devices groups) so the
   generator_definition has a target group; new `NetworkTenant` objects join it.
 
 ## Trigger (`objects/20_triggers.yml(.save)`)
+
 Add, mirroring the existing pod/rack trigger pattern:
+
 - `CoreGeneratorAction`: `run-tenant-generator` → `generate-tenant`.
 - `CoreNodeTriggerRule`: fires on `NetworkTenant` mutations (checksum + relevant attributes/relationships:
   vrfs, segments, placement) → `run-tenant-generator`.
 
 ## Idempotency / loop-prevention contract
+
 - OverlayGenerator writes `Device.segments` on leafs. The Rack/Pod generators' `GeneratorMixin` checksums
   **must exclude** overlay relationships so this write does not re-trigger the physical cascade (D12 caveat).
 - `overlay_asn` allocation in the FabricGenerator must be guarded ("allocate only if unset") and excluded

specs/001-evpn-overlay/data-model.md

@@ -8,6 +8,7 @@ schema changes.
 ## New nodes (`schemas/overlay.yml`)
 
 ### NetworkTenant
+
 Owner of overlay services, scoped to one fabric. `inherit_from: [GeneratorTarget]` (checksum drives the
 OverlayGenerator; the checksum must cover its VRFs/Segments/placement).
 
@@ -22,6 +23,7 @@ OverlayGenerator; the checksum must cover its VRFs/Segments/placement).
 | `ip_namespace` | CoreIPNamespace | one | Attribute | optional; **reserved** for future overlapping-tenant space (D10) |
 
 ### NetworkVrf
+
 A tenant's L3 routing instance (IP-VRF / L3VNI). Parent = Tenant.
 
 | Attribute | Kind | Notes |
@@ -40,6 +42,7 @@ A tenant's L3 routing instance (IP-VRF / L3VNI). Parent = Tenant.
 | `ip_namespace` | CoreIPNamespace | one | Attribute | optional; reserved (D10) |
 
 ### NetworkSegment
+
 A tenant L2 service (MAC-VRF / L2VNI). One VLAN ↔ one L2VNI (D7). Parent = VRF. Optional gateway ⇒ IRB vs
 L2-only (D5).
 
@@ -60,18 +63,21 @@ L2-only (D5).
 ## Edits to existing nodes
 
 ### NetworkFabric (`schemas/logical_design.yml`)
+
 | New attribute | Kind | Notes |
 |---------------|------|-------|
 | `overlay_asn` | Number | optional; **allocated by FabricGenerator from the global ASN pool** (D8) |
 | `routing_design` | Dropdown | choices `ibgp_evpn_ospf_underlay` (default), `ebgp_evpn` (reserved — D13/extensibility) |
 | `anycast_gateway_mac` | Text | optional override; template constant default (D10) |
 
 ### NetworkPod (`schemas/logical_design.yml`)
+
 | New relationship | Peer | Card. | Kind | Notes |
 |------------------|------|-------|------|-------|
 | `vtep_pool` | CoreIPAddressPool | one | Attribute | optional; mirrors `loopback_pool`; created by PodGenerator (D4) |
 
 ### NetworkDevice (`schemas/device.yml`)
+
 | New attribute | Kind | Notes |
 |---------------|------|-------|
 | `asn` | Number | optional; stamped `= fabric.overlay_asn` (iBGP); per-device unique under eBGP later (D8) |
@@ -85,10 +91,12 @@ L2-only (D5).
 the template (D13).
 
 ### NetworkInterface (`schemas/device.yml`)
+
 - Add roles to the `role` dropdown: `vtep` (leaf loopback1 / NVE source) and `svi` (anycast gateway + L3
   transit SVIs).
 
 ### IpamIPPrefix (`schemas/ipam.yml`)
+
 - Add `role` choices: `pod_vtep_loopback` (per-pod VTEP loopback pool), `overlay_supernet` (tenant address
   space root), `tenant_subnet` (per-segment anycast-gateway subnet).
 

specs/001-evpn-overlay/quickstart.md

@@ -36,6 +36,7 @@ inv start           # bring up the stack; generators run via triggers
 ```
 
 **Expected after generators settle**:
+
 - Every device has `asn == its fabric.overlay_asn` (allocated once from the global ASN pool).
 - Each **leaf** has a `vtep_ip` and a `vtep`-role loopback interface; **spines/super-spines** do not.
 - The seed tenant (e.g. "Blue") has a VRF with an allocated `l3vni` + `l3_vlan_id` + `route_target`, and its
@@ -50,6 +51,7 @@ allocated ids + `route_target`; query a leaf `NetworkDevice` and confirm `segmen
 ## 4. Inspect the rendered config artifact (the core proof — User Story 1)
 
 Open the `startup_configuration` artifact for a **leaf** and confirm (per `contracts/config-artifact.md`):
+
 - OSPF underlay intact, now advertising the vtep loopback.
 - `router bgp <asn>` with iBGP L2VPN-EVPN neighbors to its cabled spines.
 - `interface nve1` (source = loopback1), per-segment `member vni <l2vni>`, per-VRF `member vni <l3vni>

specs/001-evpn-overlay/research.md

@@ -8,25 +8,29 @@ remain.**
 ## Architecture & control plane
 
 ### D1 — Overlay scope is per-fabric
+
 - **Decision**: A Tenant and its VRFs/Segments belong to exactly one Fabric; each Fabric is an independent
   EVPN domain with its own ASN and VNI/RT space.
 - **Rationale**: Two independent Clos fabrics; fabric-local numbering is simplest and collision-free.
 - **Alternatives**: Cross-fabric tenants (rejected — requires DCI: inter-fabric gateways, RT stitching).
 
 ### D2 — Standalone OverlayGenerator beside the physical cascade
+
 - **Decision**: Tenant is a first-class design object with a dedicated OverlayGenerator (triggered by
   `NetworkTenant` checksum); physical generators get only small device-attribute extensions.
 - **Rationale**: Tenancy is orthogonal to the physical hierarchy and has its own lifecycle; preserves
   "one generator owns one concern" and a scoped day-two workflow (symmetric with add-rack).
 - **Alternatives**: Fold overlay into the Rack generator (rejected — conflates lifecycles, forces rebuilds).
 
 ### D3 — Hierarchical route reflection, leaf-only VTEPs
+
 - **Decision**: leafs = RR clients of their spines; spines = RR for leafs **and** clients of super-spines;
   super-spines = top RR. Only leafs are VTEPs.
 - **Rationale**: Canonical 5-stage design; sessions follow topology; low per-leaf session count.
 - **Alternatives**: Super-spines-only RR (rejected — more sessions/leaf, spine tier carries no EVPN).
 
 ### D8 — ASN from a global NumberPool, stamped to devices
+
 - **Decision**: A global `CoreNumberPool` → `NetworkFabric.overlay_asn`; FabricGenerator stamps
   `device.asn = overlay_asn`. Template renders `router bgp {{ device.asn }}`.
 - **Rationale**: ASN-as-allocated-resource fits the Resource Manager showcase; control-plane-agnostic value
@@ -37,24 +41,28 @@ remain.**
 ## Services & data model
 
 ### D5 — Anycast gateway optional on Segment
+
 - **Decision**: Segment is always an L2VNI bridge; subnet + anycast gateway are optional (present ⇒ IRB,
   absent ⇒ L2-only). Segment always nests under a VRF.
 - **Rationale**: Near-free flexibility; reflects real tenants with mixed routed/bridge-only segments.
 - **Alternatives**: Always-IRB (rejected — no L2-only support).
 
 ### D7 — VLAN-based service model, fabric-global VLANs
+
 - **Decision**: 1 VLAN ↔ 1 L2VNI ↔ 1 Segment; NX-OS `feature vn-segment-vlan-based`; VLAN ID is a
   fabric-consistent handle, L2VNI is the global id.
 - **Alternatives**: VLAN-aware bundle / multi-VLAN EVI (rejected — unnecessary complexity for the demo).
 
 ### D13 — Schema shape & simplifications
+
 - **Decision**: Tenant/VRF/Segment are plain `Network`-namespace nodes with `kind: Parent` relationships
   (not `NetworkBuildingBlock`). **No `route_reflector` boolean** (derived from tier ordering in the template).
   Materialize **only `Device↔Segment`** (VRF presence derived via `segment.vrf`).
 - **Rationale**: Different kinds → plain parent rels; tier ordering is the cleaner RR source and also right
   for eBGP-future; one materialized relationship is enough.
 
 ### D14 — L3VNI transit VLAN + two VLAN pools
+
 - **Decision**: Add `NetworkVrf.l3_vlan_id` for the L3VNI transit/core SVI. Two VLAN pools over disjoint
   ranges: L2 `100–3899` → `Segment.vlan_id`, L3 `3900–4094` → `Vrf.l3_vlan_id`.
 - **Rationale**: Symmetric IRB needs a transit VLAN per VRF on each carrying leaf; a NumberPool binds to one
@@ -64,31 +72,36 @@ remain.**
 ## Allocation, addressing, placement, triggering
 
 ### D6 — VLAN/L2VNI/L3VNI from per-fabric NumberPools
+
 - **Decision**: NumberPools (Resource Manager), not deterministic compute. Ranges: VLAN-L2 100–3899,
   VLAN-L3 3900–4094, L2VNI 10000–19999, L3VNI 50000–59999.
 - **Rationale**: On-brand with the solution's RM teaching point; queryable, collision-free.
 - **Alternatives**: `VNI = base + VLAN` (noted as the simpler documented alternative).
 
 ### D9 — RT stored (generator-set, queryable); RD template-rendered
+
 - **Decision**: OverlayGenerator stores `route_target = "<asn>:<vni>"` on VRF/Segment; RD is per-device →
   rendered in template `<loopback0>:<id>`. Optional `import_rt`/`export_rt` overrides reserved.
 - **Rationale**: Queryable source of truth without computed-attr relationship-traversal risk; RD has no
   single home object.
 - **Alternatives**: Computed-attribute RT (traversal uncertain); NX-OS `auto` (hides RD/RT from Infrahub).
 
 ### D10 — Separate overlay supernet; default IP namespace first
+
 - **Decision**: New IPPrefix roles `overlay_supernet` + `tenant_subnet`; segment subnets from an overlay
   supernet distinct from underlay `10.0.0.0/8`. Anycast GW = `.1`, distributed; fabric-wide
   `anycast-gateway-mac` (template constant + optional Fabric override). Default namespace initially;
   optional `ip_namespace` on VRF/Tenant reserved for overlapping tenant space.
 - **Alternatives**: Per-VRF namespaces now (deferred — heavier generator bookkeeping for a phase-2 toggle).
 
 ### D4 — Dedicated VTEP loopback1 on leafs
+
 - **Decision**: Leaf loopback1 (role `vtep`) as NVE source; advertised in OSPF; allocated from a per-pod
   VTEP pool (role `pod_vtep_loopback`). loopback0 stays router-id/iBGP source. Spines/super-spines: none.
 - **Rationale**: Standard best practice; keeps anycast-VTEP/MLAG open; role-based IPAM consistency.
 
 ### D11/D12 — Placement (advertise-all default) via materialized relationship (Design Y)
+
 - **Decision**: Optional `Segment↔Rack` placement intent (empty ⇒ every leaf in fabric). OverlayGenerator
   materializes `Device↔Segment` onto carrying leafs; leaf-device change rides the existing
   device→artifact regeneration path.

src/infrahub_solution_ai_dc/cabling.py

@@ -50,7 +50,7 @@ def build_rack_cabling_plan(
     dst_device_count = len(dst_devices)
 
     for src_device, src_interfaces in src_interface_map.items():
-        src_device_index: int = src_device.index.value  # type: ignore[attr-defined]
+        src_device_index: int = src_device.index.value  # type: ignore[assignment]
 
         for dst_index, src_interface in enumerate(src_interfaces[:dst_device_count]):
             start = (rack_index * 2) - 2