Skip to content

Skip orphan artifacts when validating artifact generation#9192

Merged
ogenstad merged 1 commit into
stablefrom
pog-artifact-generation-IFC-2569
May 11, 2026
Merged

Skip orphan artifacts when validating artifact generation#9192
ogenstad merged 1 commit into
stablefrom
pog-artifact-generation-IFC-2569

Conversation

@ogenstad
Copy link
Copy Markdown
Contributor

@ogenstad ogenstad commented May 8, 2026

Why

Orphaned artifacts were preventing the artifact generation in the pipeline to work, this change ensures that the pipeline doesn't get impacted if something like this were to happen.

Closes #9188

What changed

  • A new check to avoid including orphans which would break cause later exceptions
  • Small refactoring to break out a piece of the code to an external function. The reason for this was that the code body was getting too long and complex. It's still hard to read and parse and could benefit from a larger refactoring.
  • Added tests

@github-actions github-actions Bot added the group/backend Issue related to the backend (API Server, Git Agent) label May 8, 2026
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented May 8, 2026

Merging this PR will not alter performance

✅ 12 untouched benchmarks


Comparing pog-artifact-generation-IFC-2569 (6230d12) with stable (045500f)

Open in CodSpeed

@ogenstad ogenstad marked this pull request as ready for review May 8, 2026 13:36
@ogenstad ogenstad requested a review from a team as a code owner May 8, 2026 13:36
@ogenstad ogenstad merged commit 8689f7d into stable May 11, 2026
46 checks passed
@ogenstad ogenstad deleted the pog-artifact-generation-IFC-2569 branch May 11, 2026 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

group/backend Issue related to the backend (API Server, Git Agent)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: validate_artifacts_generation crashes on artifacts with unresolvable object peers, blocking artifact generation for all group members

2 participants