Commit 667866e
committed
fix(bench): sync JS fixture names and use super.count() in DoubleCounter (#1331)
Two bugs introduced by the fix(lint) commit (4ed709e):
1. define-property.js functions were renamed defProp/defProps/create → _defProp/
_defProps/_create (to suppress biome noUnusedVariables), but expected-edges.json
was not updated. This caused 5 false positives and 5 false negatives in the
benchmark (precision 84.4%, recall 81.8%).
2. DoubleCounter.count was changed from super.count() to Counter.count() by the
same lint fix commit. The fixture is meant to test static class-inheritance
resolution via super.count(); reverting to Counter.count() made the edge a
plain same-file call, causing the class-inheritance recall to drop to 2/3.
Fix: update expected-edges.json names to match renamed functions; restore
super.count() in inheritance.js with a biome-ignore suppression explaining
the intent.1 parent 66b899a commit 667866e
2 files changed
Lines changed: 7 additions & 6 deletions
Lines changed: 5 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
130 | 130 | | |
131 | 131 | | |
132 | 132 | | |
133 | | - | |
| 133 | + | |
134 | 134 | | |
135 | 135 | | |
136 | 136 | | |
137 | 137 | | |
138 | 138 | | |
139 | 139 | | |
140 | | - | |
| 140 | + | |
141 | 141 | | |
142 | 142 | | |
143 | 143 | | |
144 | 144 | | |
145 | 145 | | |
146 | 146 | | |
147 | | - | |
| 147 | + | |
148 | 148 | | |
149 | 149 | | |
150 | 150 | | |
151 | 151 | | |
152 | 152 | | |
153 | 153 | | |
154 | | - | |
| 154 | + | |
155 | 155 | | |
156 | 156 | | |
157 | 157 | | |
158 | 158 | | |
159 | 159 | | |
160 | 160 | | |
161 | | - | |
| 161 | + | |
162 | 162 | | |
163 | 163 | | |
164 | 164 | | |
| |||
Lines changed: 2 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
29 | 29 | | |
30 | 30 | | |
31 | 31 | | |
32 | | - | |
| 32 | + | |
| 33 | + | |
33 | 34 | | |
34 | 35 | | |
0 commit comments