fix(resolver): clarify scope guard and :this key convention in accessor this-dispatch (#1351)

- Add comment to extractConstDeclarators explaining that the function-scope guard
  is upheld by the caller (extractConstantsWalk) — future refactors must add a
  hasFunctionScopeAncestor check before calling extractObjectLiteralFunctions from
  any other context.
- Add comment at the setTypeMapEntry call noting that ':' is a reserved separator for
  Phase 8.3f keys and cannot collide with real JS identifier names.

Author: carlos-alm

src/extractors/javascript.ts

@@ -498,6 +498,10 @@ function extractConstDeclarators(declNode: TreeSitterNode, definitions: Definiti
         endLine: nodeEndLine(declNode),
       });
       // Phase 8.3f: extract function/arrow properties from object literals.
+      // Scope guard: extractConstDeclarators is only called from extractConstantsWalk, which
+      // already skips const declarations inside function scopes (line ~412). So these definitions
+      // are always top-level. Do not call extractObjectLiteralFunctions from any other context
+      // without adding a hasFunctionScopeAncestor guard first.
       if (valueN.type === 'object') {
         extractObjectLiteralFunctions(valueN, nameN.text, definitions);
       }
@@ -1776,6 +1780,8 @@ function handleDefinePropertyTypeMap(
       setTypeMapEntry(typeMap, `${arg0.text}.${key}`, target, 0.85);
     }
     // Phase 8.3f: { get: getter } and/or { set: setter } → this inside each accessor is arg0 (obj)
+    // Key format: '<accessorName>:this' — colon is a reserved separator used only by this phase.
+    // JS identifiers cannot contain ':', so this key never collides with real variable names.
     for (const accessor of findDescriptorAccessors(arg2)) {
       setTypeMapEntry(typeMap, `${accessor}:this`, arg0.text, 0.85);
     }