fix: WASM build resilience + lint cleanup from TS migration (#629)

* fix: make WASM grammar build resilient to transient failures

The prepare script now treats build:wasm as non-fatal since the native
engine is the primary parser. Individual grammar build failures are
caught and warned instead of aborting the entire build.

* fix(lint): disable noNonNullAssertion and noExplicitAny rules, clean up suppressions

These rules produce hundreds of warnings from the JS→TS migration (Phase 6)
and are not actionable yet. Auto-fixed useLiteralKeys and noUnusedImports,
removed 69 now-unnecessary biome-ignore comments, and deleted one unused
interface.

* fix: disable noPropertyAccessFromIndexSignature, clean up useLiteralKeys suppressions (#629)

tsconfig's noPropertyAccessFromIndexSignature conflicted with biome's
useLiteralKeys auto-fix, causing TS4111 errors on CI. Disable the TS
rule so dot notation is valid for index signatures. Remove all
now-unnecessary useLiteralKeys biome-ignore comments and convert
remaining bracket notation. Also fix duplicate | undefined in types.ts
and delete dead _taSub function in leiden adapter.

* fix: make WASM build non-fatal without bash-only syntax (#629)

The prepare script used bash-style (cmd || echo) which fails on Windows
cmd.exe. Instead, make build-wasm.ts always exit 0 since failures are
already non-fatal by design (per-grammar try/catch with warning logs).
This restores the simple prepare script while keeping WASM resilience.

Author: carlos-alm

biome.json

@@ -10,7 +10,13 @@
   },
   "linter": {
     "rules": {
-      "recommended": true
+      "recommended": true,
+      "style": {
+        "noNonNullAssertion": "off"
+      },
+      "suspicious": {
+        "noExplicitAny": "off"
+      }
     }
   },
   "javascript": {

scripts/build-wasm.ts

@@ -36,17 +36,27 @@ const grammars = [
   { name: 'tree-sitter-php', pkg: 'tree-sitter-php', sub: 'php' },
 ];
 
+let failed = 0;
 for (const g of grammars) {
   const pkgDir = dirname(require.resolve(`${g.pkg}/package.json`));
   const grammarDir = g.sub ? resolve(pkgDir, g.sub) : pkgDir;
 
   console.log(`Building ${g.name}.wasm from ${grammarDir}...`);
-  execFileSync('npx', ['tree-sitter', 'build', '--wasm', grammarDir], {
-    cwd: grammarsDir,
-    stdio: 'inherit',
-    shell: true,
-  });
-  console.log(`  Done: ${g.name}.wasm`);
+  try {
+    execFileSync('npx', ['tree-sitter', 'build', '--wasm', grammarDir], {
+      cwd: grammarsDir,
+      stdio: 'inherit',
+      shell: true,
+    });
+    console.log(`  Done: ${g.name}.wasm`);
+  } catch (err: any) {
+    failed++;
+    console.warn(`  WARN: Failed to build ${g.name}.wasm — ${err.message ?? 'unknown error'}`);
+  }
 }
 
-console.log('\nAll grammars built successfully into grammars/');
+if (failed > 0) {
+  console.warn(`\n${failed}/${grammars.length} grammars failed to build (non-fatal — native engine available)`);
+} else {
+  console.log('\nAll grammars built successfully into grammars/');
+}

src/ast-analysis/engine.ts

@@ -219,7 +219,6 @@ function setupVisitors(
       walkerOpts.getFunctionName = (node: TreeSitterNode): string | null => {
         const nameNode = node.childForFieldName('name');
         if (nameNode) return nameNode.text;
-        // biome-ignore lint/suspicious/noExplicitAny: DataflowRulesConfig is structurally compatible at runtime
         if (dfRules) return getFuncName(node, dfRules as any);
         return null;
       };
@@ -260,8 +259,7 @@ function setupVisitors(
 // ─── Result storage helpers ─────────────────────────────────────────────
 
 function storeComplexityResults(results: WalkResults, defs: Definition[], langId: string): void {
-  // biome-ignore lint/complexity/useLiteralKeys: bracket notation required by noPropertyAccessFromIndexSignature
-  const complexityResults = (results['complexity'] || []) as ComplexityFuncResult[];
+  const complexityResults = (results.complexity || []) as ComplexityFuncResult[];
   const resultByLine = new Map<number, ComplexityFuncResult[]>();
   for (const r of complexityResults) {
     if (r.funcNode) {
@@ -302,8 +300,7 @@ function storeComplexityResults(results: WalkResults, defs: Definition[], langId
 }
 
 function storeCfgResults(results: WalkResults, defs: Definition[]): void {
-  // biome-ignore lint/complexity/useLiteralKeys: bracket notation required by noPropertyAccessFromIndexSignature
-  const cfgResults = (results['cfg'] || []) as CfgFuncResult[];
+  const cfgResults = (results.cfg || []) as CfgFuncResult[];
   const cfgByLine = new Map<number, CfgFuncResult[]>();
   for (const r of cfgResults) {
     if (r.funcNode) {
@@ -362,7 +359,6 @@ async function delegateToBuildFunctions(
     const t0 = performance.now();
     try {
       const { buildAstNodes } = await import('../features/ast.js');
-      // biome-ignore lint/suspicious/noExplicitAny: ExtractorOutput is a superset of the local FileSymbols expected by buildAstNodes
       await buildAstNodes(db, fileSymbols as Map<string, any>, rootDir, engineOpts);
     } catch (err: unknown) {
       debug(`buildAstNodes failed: ${(err as Error).message}`);
@@ -374,7 +370,6 @@ async function delegateToBuildFunctions(
     const t0 = performance.now();
     try {
       const { buildComplexityMetrics } = await import('../features/complexity.js');
-      // biome-ignore lint/suspicious/noExplicitAny: ExtractorOutput is a superset of the local FileSymbols expected by buildComplexityMetrics
       await buildComplexityMetrics(db, fileSymbols as Map<string, any>, rootDir, engineOpts);
     } catch (err: unknown) {
       debug(`buildComplexityMetrics failed: ${(err as Error).message}`);
@@ -453,8 +448,7 @@ export async function runAnalyses(
 
     if (complexityVisitor) storeComplexityResults(results, defs, langId);
     if (cfgVisitor) storeCfgResults(results, defs);
-    // biome-ignore lint/complexity/useLiteralKeys: bracket notation required by noPropertyAccessFromIndexSignature
-    if (dataflowVisitor) symbols.dataflow = results['dataflow'] as DataflowResult;
+    if (dataflowVisitor) symbols.dataflow = results.dataflow as DataflowResult;
   }
 
   timing._unifiedWalkMs = performance.now() - t0walk;

src/ast-analysis/shared.ts

@@ -176,7 +176,6 @@ export function findFunctionNode(
     }
 
     for (let i = 0; i < node.childCount; i++) {
-      // biome-ignore lint/style/noNonNullAssertion: tree-sitter child(i) within childCount is always non-null
       search(node.child(i)!);
     }
   }

src/ast-analysis/visitors/cfg-shared.ts

@@ -1,6 +1,5 @@
 import type { TreeSitterNode } from '../../types.js';
 
-// biome-ignore lint/suspicious/noExplicitAny: CFG rules are opaque language-specific objects
 export type AnyRules = any;
 
 /** Callback type for the mutual recursion with processStatements in cfg-visitor. */

src/ast-analysis/visitors/complexity-visitor.ts

@@ -5,7 +5,6 @@ import {
   computeMaintainabilityIndex,
 } from '../metrics.js';
 
-// biome-ignore lint/suspicious/noExplicitAny: complexity/halstead rules are opaque language-specific objects
 type AnyRules = any;
 
 interface ComplexityAcc {

src/ast-analysis/visitors/dataflow-visitor.ts

@@ -10,7 +10,6 @@ import {
   truncate,
 } from '../visitor-utils.js';
 
-// biome-ignore lint/suspicious/noExplicitAny: dataflow rules are opaque language-specific objects
 type AnyRules = any;
 
 interface ScopeEntry {

src/cli/commands/branch-compare.ts

@@ -13,7 +13,7 @@ export const command: CommandDefinition = {
   async execute([base, target], opts, ctx) {
     const { branchCompare } = await import('../../presentation/branch-compare.js');
     await branchCompare(base!, target!, {
-      engine: ctx.program.opts()['engine'],
+      engine: ctx.program.opts().engine,
       depth: parseInt(opts.depth as string, 10),
       noTests: ctx.resolveNoTests(opts),
       json: opts.json,

src/cli/commands/build.ts

@@ -15,7 +15,7 @@ export const command: CommandDefinition = {
   ],
   async execute([dir], opts, ctx) {
     const root = path.resolve(dir || '.');
-    const engine = ctx.program.opts()['engine'];
+    const engine = ctx.program.opts().engine;
     await buildGraph(root, {
       incremental: opts.incremental as boolean,
       ast: opts.ast as boolean,

src/cli/commands/info.ts

@@ -9,7 +9,7 @@ export const command: CommandDefinition = {
     );
     const { getActiveEngine } = await import('../../domain/parser.js');
 
-    const engine = ctx.program.opts()['engine'];
+    const engine = ctx.program.opts().engine;
     const { name: activeName, version: activeVersion } = getActiveEngine({ engine });
     const nativeAvailable = isNativeAvailable();