fix: resolve readonly array includes TS errors from main merge

EVERY_SYMBOL_KIND and CORE_SYMBOL_KINDS are readonly-typed after
kinds.js was converted to kinds.ts in #553. Array.prototype.includes
on a readonly T[] rejects a wider argument type — cast to
readonly string[] at call sites where the argument is string/AnyNodeKind.
Also spread CORE_SYMBOL_KINDS where a mutable string[] is expected.

Author: carlos-alm

src/db/repository/in-memory-repository.ts

@@ -286,7 +286,7 @@ export class InMemoryRepository extends Repository {
   }
 
   findNodesForTriage(opts: TriageQueryOpts = {}): NodeRow[] {
-    if (opts.kind && !EVERY_SYMBOL_KIND.includes(opts.kind)) {
+    if (opts.kind && !(EVERY_SYMBOL_KIND as readonly string[]).includes(opts.kind)) {
       throw new ConfigError(
         `Invalid kind: ${opts.kind} (expected one of ${EVERY_SYMBOL_KIND.join(', ')})`,
       );
@@ -563,7 +563,7 @@ export class InMemoryRepository extends Repository {
 
   getCallableNodes(): CallableNodeRow[] {
     return [...this.#nodes.values()]
-      .filter((n) => CORE_SYMBOL_KINDS.includes(n.kind))
+      .filter((n) => (CORE_SYMBOL_KINDS as readonly string[]).includes(n.kind))
       .map((n) => ({ id: n.id, name: n.name, kind: n.kind, file: n.file }));
   }
 

src/db/repository/nodes.ts

@@ -46,7 +46,7 @@ export function findNodesForTriage(
   db: BetterSqlite3Database,
   opts: TriageQueryOpts = {},
 ): NodeRow[] {
-  if (opts.kind && !EVERY_SYMBOL_KIND.includes(opts.kind)) {
+  if (opts.kind && !(EVERY_SYMBOL_KIND as readonly string[]).includes(opts.kind)) {
     throw new ConfigError(
       `Invalid kind: ${opts.kind} (expected one of ${EVERY_SYMBOL_KIND.join(', ')})`,
     );

src/domain/analysis/implementations.ts

@@ -27,7 +27,7 @@ export function implementationsData(
       noTests,
       file: opts.file,
       kind: opts.kind,
-      kinds: opts.kind ? undefined : CORE_SYMBOL_KINDS,
+      kinds: opts.kind ? undefined : [...CORE_SYMBOL_KINDS],
     });
     if (nodes.length === 0) {
       return { name, results: [] };
@@ -78,7 +78,7 @@ export function interfacesData(
       noTests,
       file: opts.file,
       kind: opts.kind,
-      kinds: opts.kind ? undefined : CORE_SYMBOL_KINDS,
+      kinds: opts.kind ? undefined : [...CORE_SYMBOL_KINDS],
     });
     if (nodes.length === 0) {
       return { name, results: [] };