fix(perf): broaden Gate B to cover constructor/function-kind RTA fallback schema

Gate B previously checked only `tgt.kind = 'class'`, but the RTA seed has a
fallback that matches `tgt.kind IN ('constructor', 'function')` when no
class-kind constructor edges exist (older native engine schemas). On codebases
where the fallback path is always active, Gate B would never fire, causing
scopeToChangedFiles to be set incorrectly and silently dropping CHA edges for
unchanged callers whose RTA evidence lives in the fallback-schema rows.

Broaden Gate B to `tgt.kind IN ('class', 'constructor', 'function')` to mirror
the full two-shape RTA seed. Also fix formatter violation on the .all() cast.

Author: carlos-alm

src/domain/graph/builder/stages/native-orchestrator.ts

@@ -406,9 +406,11 @@ async function runPostNativeAnalysis(
  *   - array → incremental; two cheap gate queries decide scope:
  *       Gate A: any class/interface/trait/struct/record nodes in changed files?
  *               If yes, a new implementor may have appeared — full scan required.
- *       Gate B: any `calls` edges from changed-file sources targeting class-kind
- *               nodes? If yes, the RTA set may have grown, enabling previously
- *               filtered expansions in unchanged caller files — full scan required.
+ *       Gate B: any `calls` edges from changed-file sources targeting
+ *               class/constructor/function-kind nodes? If yes, the RTA set may
+ *               have grown (also covers the older-schema fallback where
+ *               constructor calls target `constructor`/`function` nodes instead
+ *               of `class` nodes) — full scan required.
  *       If neither gate fires: scope `callToMethods` to `src.file IN changedFiles`
  *       (safe because no hierarchy or RTA evidence changed).
  *
@@ -498,9 +500,10 @@ function runPostNativeCha(
   //   valid expansions, so the full scan is required.
   //
   // Gate B: did a changed file add new RTA evidence (`new ConcreteX()`)?
-  //   A new `calls` edge to a class-kind target means the instantiated set grew —
-  //   previously RTA-filtered expansions in unchanged caller files become
-  //   admissible, so the full scan is required.
+  //   A new `calls` edge to a class/constructor/function-kind target means the
+  //   instantiated set grew — previously RTA-filtered expansions in unchanged
+  //   caller files become admissible, so the full scan is required.
+  //   (`constructor`/`function` cover the older native engine fallback schema.)
   //
   // If neither gate fires, the hierarchy and RTA set are unchanged for all files
   // outside changedFiles, so restricting to changed-file sources is safe.
@@ -523,7 +526,13 @@ function runPostNativeCha(
       if (row) gateAFired = true;
     }
 
-    // Gate B: calls from changed-file sources to class-kind targets?
+    // Gate B: calls from changed-file sources to class-kind targets (or
+    // constructor/function-kind targets in the older native engine fallback schema)?
+    // Mirrors the two-shape RTA seed: primary checks `tgt.kind = 'class'`; older
+    // native engine schemas record constructor calls against `constructor`/`function`
+    // kinds instead. Including all three kinds here prevents Gate B from silently
+    // passing on older-schema DBs, which would incorrectly set scopeToChangedFiles
+    // and miss CHA edges whose RTA evidence lives in the fallback-schema rows.
     let gateBFired = false;
     if (!gateAFired) {
       for (let i = 0; i < changedFiles.length && !gateBFired; i += CHUNK_SIZE) {
@@ -534,7 +543,8 @@ function runPostNativeCha(
             `SELECT 1 FROM edges e
              JOIN nodes src ON e.source_id = src.id
              JOIN nodes tgt ON e.target_id = tgt.id
-             WHERE e.kind = 'calls' AND tgt.kind = 'class'
+             WHERE e.kind = 'calls'
+             AND tgt.kind IN ('class', 'constructor', 'function')
              AND src.file IN (${ph})
              LIMIT 1`,
           )
@@ -577,7 +587,11 @@ function runPostNativeCha(
            AND INSTR(tgt.name, '.') > 0
            AND src.file IN (${ph})`,
         )
-        .all(...chunk) as Array<{ source_id: number; method_name: string; caller_file: string | null }>;
+        .all(...chunk) as Array<{
+        source_id: number;
+        method_name: string;
+        caller_file: string | null;
+      }>;
       rows.push(...chunkRows);
     }
     callToMethods = rows;