fix: guard timeMedianWithValue against runs=0 (#2016)

carlos-alm · carlos-alm · commit aada0450949b · 2026-07-08T02:19:21.000-06:00
docs check acknowledged — defensive guard only, not reachable at current call sites.

Impact: 1 functions changed, 2 affected
diff --git a/scripts/lib/bench-timing.ts b/scripts/lib/bench-timing.ts
@@ -81,6 +81,9 @@ export async function timeMedianWithValue<T>(
 		const value = await fn(i);
 		samples.push({ ms: performance.now() - start, value });
 	}
+	if (samples.length === 0) {
+		throw new Error('timeMedianWithValue: runs must be >= 1');
+	}
 	samples.sort((a, b) => a.ms - b.ms);
 	return samples[Math.floor(samples.length / 2)];
 }

Original file line number	Diff line number	Diff line change
`@@ -81,6 +81,9 @@ export async function timeMedianWithValue<T>(`
`81`	`81`	`const value = await fn(i);`
`82`	`82`	`samples.push({ ms: performance.now() - start, value });`
`83`	`83`	`}`
	`84`	`+ if (samples.length === 0) {`
	`85`	`+ throw new Error('timeMedianWithValue: runs must be >= 1');`
	`86`	`+ }`
`84`	`87`	`samples.sort((a, b) => a.ms - b.ms);`
`85`	`88`	`return samples[Math.floor(samples.length / 2)];`
`86`	`89`	`}`