fix(native): expand super-dispatch edges into CHA sibling overrides (#1544)

* fix(native): expand super-dispatch edges into CHA sibling overrides (#1544)

runPostNativeCha was filtering out edges with technique='cha', which
prevented it from expanding the super.method() → Parent.method edges
inserted by runPostNativeThisDispatch (which also uses technique='cha').
Additionally, runPostNativeCha was running before runPostNativeThisDispatch,
so the super-dispatch seed edges were not yet in the DB when the BFS
expansion ran.

Two changes fix parity with WASM:
1. Reorder so runPostNativeThisDispatch runs first, putting the
   technique='cha' seed edges in the DB before the expansion pass reads
   them.
2. Rename the CHA expansion output to technique='cha-expanded' and update
   both filter queries (native and WASM runChaPostPass) from != 'cha'
   to != 'cha-expanded'. This lets the expansion pass see 'cha'-tagged
   super-dispatch edges while still preventing infinite re-expansion of its
   own output edges.

After this fix, native produces 6 CHA edges that WASM already emitted
(e.g. PostMixin.m → B.m across jelly-micro fixtures where PostMixin and B
both extend A).

Closes #1544

* fix(cha): renumber CHA expansion post-pass to Phase 8.6

runPostNativeThisDispatch now runs before runPostNativeCha, making
the previous dual "Phase 8.5" labels misleading. Renumber the CHA
expansion pass (runPostNativeCha) to Phase 8.6 so the orchestrator
numbering is monotonic and matches execution order.

Author: carlos-alm

src/domain/graph/builder/helpers.ts

@@ -48,9 +48,9 @@ export const BUILTIN_RECEIVERS: Set<string> = new Set([
   'require',
 ]);
 
-/** Phase 8.5: confidence penalty applied to CHA-dispatch edges. */
+/** Phase 8.6: confidence penalty applied to CHA-dispatch edges. */
 export const CHA_DISPATCH_PENALTY = 0.1;
-/** Phase 8.5: fixed confidence for typed-receiver (interface/CHA) dispatch edges.
+/** Phase 8.6: fixed confidence for typed-receiver (interface/CHA) dispatch edges.
  *  File proximity is not meaningful for virtual dispatch — all three engine paths
  *  (WASM inline, WASM post-pass, native post-pass) must agree on this value. */
 export const CHA_TYPED_DISPATCH_CONFIDENCE = 0.8;
@@ -470,7 +470,7 @@ export function runChaPostPass(db: BetterSqlite3Database): number {
        JOIN nodes src ON e.source_id = src.id
        WHERE e.kind = 'calls' AND tgt.kind = 'method'
        AND INSTR(tgt.name, '.') > 0
-       AND (e.technique IS NULL OR e.technique != 'super-dispatch')`,
+       AND (e.technique IS NULL OR e.technique != 'cha-expanded')`,
     )
     .all() as Array<{ source_id: number; caller_name: string; method_name: string }>;
 
@@ -533,7 +533,7 @@ export function runChaPostPass(db: BetterSqlite3Database): number {
               'calls',
               CHA_TYPED_DISPATCH_CONFIDENCE,
               0,
-              'cha',
+              'cha-expanded',
             ]);
           }
         }

src/domain/graph/builder/stages/native-orchestrator.ts

@@ -390,7 +390,7 @@ async function runPostNativeAnalysis(
 }
 
 /**
- * Phase 8.5: CHA expansion post-pass for the native orchestrator path.
+ * Phase 8.6: CHA expansion post-pass for the native orchestrator path.
  *
  * The Rust build pipeline resolves typed receiver calls (e.g. `worker.doWork()`
  * where `worker: IWorker`) to the interface method declaration only.  This
@@ -597,7 +597,7 @@ function runPostNativeCha(
            JOIN nodes src ON e.source_id = src.id
            WHERE e.kind = 'calls' AND tgt.kind = 'method'
            AND INSTR(tgt.name, '.') > 0
-           AND (e.technique IS NULL OR e.technique != 'super-dispatch')
+           AND (e.technique IS NULL OR e.technique != 'cha-expanded')
            AND src.file IN (${ph})`,
         )
         .all(...chunk) as Array<{
@@ -618,7 +618,7 @@ function runPostNativeCha(
         JOIN nodes src ON e.source_id = src.id
         WHERE e.kind = 'calls' AND tgt.kind = 'method'
         AND INSTR(tgt.name, '.') > 0
-        AND (e.technique IS NULL OR e.technique != 'super-dispatch')
+        AND (e.technique IS NULL OR e.technique != 'cha-expanded')
       `)
       .all() as Array<{
       source_id: number;
@@ -685,7 +685,7 @@ function runPostNativeCha(
             if (seen.has(key)) continue;
             seen.add(key);
             const conf = CHA_TYPED_DISPATCH_CONFIDENCE;
-            newEdges.push([source_id, methodNode.id, 'calls', conf, 0, 'cha']);
+            newEdges.push([source_id, methodNode.id, 'calls', conf, 0, 'cha-expanded']);
             newEdgeCount++;
             if (caller_file) affectedFiles.add(caller_file);
             if (methodNode.method_file) affectedFiles.add(methodNode.method_file);
@@ -1600,10 +1600,31 @@ export async function tryNativeOrchestrator(
   }
   const gapDetectMs = performance.now() - gapDetectStart;
 
-  // Phase 8.5: expand CHA call edges (interface dispatch → concrete implementations).
+  // Phase 8.5: this/super dispatch — hybrid WASM re-parse to resolve call sites
+  // whose raw receiver info the Rust pipeline does not persist to DB.
+  // Runs BEFORE the CHA expansion pass so that super.method() → Parent.method edges
+  // (technique='cha') are in the DB when runPostNativeCha expands them to sibling
+  // class overrides (e.g. PostMixin.m → B.m when PostMixin and B both extend A).
+  const {
+    elapsedMs: thisDispatchMs,
+    targetIds: thisDispatchTargetIds,
+    affectedFiles: thisDispatchAffectedFiles,
+  } = await runPostNativeThisDispatch(
+    ctx.db as unknown as BetterSqlite3Database,
+    ctx.rootDir,
+    result.changedFiles,
+    !!result.isFullBuild,
+  );
+
+  // Phase 8.6: expand CHA call edges (interface dispatch → concrete implementations).
   // Returns the affected files so role re-classification below can be scoped to
   // the nodes whose fan-in/out actually changed.
   //
+  // Runs AFTER this/super dispatch so super.method() edges are already in the DB.
+  // The 'cha-expanded' technique tag on this pass's own output prevents re-expansion
+  // of those edges in subsequent incremental builds, while 'cha'-tagged edges from
+  // this/super dispatch remain eligible for expansion here.
+  //
   // Function-as-object-property methods (`fn.method = function() {}`) are extracted
   // natively by the Rust engine (#1432) and resolved in-build by its edge builder, so
   // no WASM re-parse post-pass is needed for them. `Foo.prototype.bar = fn` likewise.
@@ -1615,19 +1636,6 @@ export async function tryNativeOrchestrator(
   );
   const chaMs = performance.now() - chaStart;
 
-  // Phase 8.5: this/super dispatch — hybrid WASM re-parse to resolve call sites
-  // whose raw receiver info the Rust pipeline does not persist to DB.
-  const {
-    elapsedMs: thisDispatchMs,
-    targetIds: thisDispatchTargetIds,
-    affectedFiles: thisDispatchAffectedFiles,
-  } = await runPostNativeThisDispatch(
-    ctx.db as unknown as BetterSqlite3Database,
-    ctx.rootDir,
-    result.changedFiles,
-    !!result.isFullBuild,
-  );
-
   // Role re-classification after JS edge-writing post-passes.
   // The Rust orchestrator classifies roles before these post-passes (CHA,
   // this-dispatch) add edges, so roles for the edge endpoints are stale.