Skip to content

Commit b78916a

Browse files
committed
docs: clarify HubTargets.mid is informational-only, not benchmarked (#2039)
mid is computed by selectHubTargets() and covered by tests, but neither benchmark.ts nor query-benchmark.ts passes it into any benchDepths/benchQuery call — it only ever reaches a console.error log line and the output JSON's targets block. This predates PR #2039 (the original pre-extraction selectTargets() had the same shape), so wiring it into an actual measurement is a distinct feature change with its own design questions (what should it measure, does the benchmark-gate baseline config need a new entry), not a determinism/kind-filter bug fix. Document the current informational-only status directly on the interface field so it isn't mistaken for an active measurement. Tracked in #2089 for whoever wants to either wire it in or drop it.
1 parent d299cf9 commit b78916a

1 file changed

Lines changed: 7 additions & 0 deletions

File tree

scripts/lib/hub-selection.ts

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,13 @@ export const PINNED_HUB_CANDIDATES: readonly string[] = ['buildGraph', 'openDb',
4343
export interface HubTargets {
4444
hub: string;
4545
hubFile: string;
46+
/**
47+
* Node at the median edge-count rank among kind-filtered candidates.
48+
* Informational only: it is recorded in benchmark output for visibility
49+
* but neither `query-benchmark.ts` nor `benchmark.ts` currently passes it
50+
* into a `benchDepths`/`benchQuery` call, so it drives no timed
51+
* measurement. See #2089 to wire it into an actual measurement or drop it.
52+
*/
4653
mid: string;
4754
leaf: string;
4855
}

0 commit comments

Comments
 (0)