ci: force rustup proxy on PATH for macos-14 x86_64 builds (#1151)

* ci: force rustup proxy on PATH for macos-14 x86_64 builds

macos-14 ARM runners intermittently expose a stale cargo binary that
resolves to rustup-init, breaking napi-rs `cargo metadata` calls during
the x86_64-apple-darwin build. Add a verification step after
dtolnay/rust-toolchain that re-prepends $HOME/.cargo/bin and runs
`cargo --version` so the failure surfaces immediately rather than deep
inside napi build.

Fixes #1136

* ci: clarify macOS rustup shim workaround scope (#1151)

Greptile noted that the step name ("macos-14 shim workaround") and PR
description suggested the fix only targets macos-14, while
runner.os == 'macOS' also covers macos-latest/aarch64-native. Issue
#1136 also recorded an aarch64-apple-darwin failure, so keeping the
broader guard is correct. Update the step name and comment to reflect
that the workaround intentionally applies to all macOS matrix entries
as a safety net.

Author: carlos-alm

.github/workflows/build-native.yml

@@ -67,6 +67,20 @@ jobs:
         with:
           targets: ${{ matrix.target }}
 
+      - name: Verify cargo resolves to rustup proxy (macOS shim workaround)
+        if: runner.os == 'macOS'
+        shell: bash
+        run: |
+          # macOS runners (most often `macos-14` ARM, but also observed on
+          # `macos-latest`/aarch64 builds — see #1136) intermittently expose
+          # a stale `cargo` on PATH that resolves to `rustup-init`, breaking
+          # `cargo metadata` invocations from napi-rs. Force the rustup
+          # proxy bin dir to the front of PATH and fail fast if cargo is
+          # unhealthy. Applied to all macOS matrix entries as a safety net.
+          echo "$HOME/.cargo/bin" >> "$GITHUB_PATH"
+          "$HOME/.cargo/bin/cargo" --version
+          "$HOME/.cargo/bin/rustc" --version
+
       - name: Rust cache
         uses: Swatinem/rust-cache@v2
         with:

.github/workflows/publish.yml

@@ -176,6 +176,20 @@ jobs:
         with:
           targets: ${{ matrix.target }}
 
+      - name: Verify cargo resolves to rustup proxy (macOS shim workaround)
+        if: runner.os == 'macOS'
+        shell: bash
+        run: |
+          # macOS runners (most often `macos-14` ARM, but also observed on
+          # `macos-latest`/aarch64 builds — see #1136) intermittently expose
+          # a stale `cargo` on PATH that resolves to `rustup-init`, breaking
+          # `cargo metadata` invocations from napi-rs. Force the rustup
+          # proxy bin dir to the front of PATH and fail fast if cargo is
+          # unhealthy. Applied to all macOS matrix entries as a safety net.
+          echo "$HOME/.cargo/bin" >> "$GITHUB_PATH"
+          "$HOME/.cargo/bin/cargo" --version
+          "$HOME/.cargo/bin/rustc" --version
+
       - name: Rust cache
         uses: Swatinem/rust-cache@v2
         with: