test(native-db): cover the remaining 3 busyTimeoutMs threading call sites (Greptile review)

Impact: 3 functions changed, 8 affected

Author: carlos-alm

src/domain/graph/builder/stages/native-orchestrator.ts

@@ -556,7 +556,7 @@ async function runDataflowVertexPass(
  * Used when the Rust addon doesn't include analysis persistence (older addon
  * version) or when analysis failed on the Rust side.
  */
-async function runPostNativeAnalysis(
+export async function runPostNativeAnalysis(
   ctx: PipelineContext,
   allFileSymbols: Map<string, ExtractorOutput>,
   changedFiles: string[] | undefined,
@@ -1950,7 +1950,7 @@ function backfillEdgeTechniquesAfterNativeOrchestrator(
  * corruption. On setup failure, falls back to reopening better-sqlite3 and
  * leaves ctx.nativeDb undefined so the caller falls through to the JS pipeline.
  */
-function openNativeDatabase(ctx: PipelineContext): void {
+export function openNativeDatabase(ctx: PipelineContext): void {
   if (ctx.nativeDb || !ctx.nativeAvailable) return;
   const native = loadNative();
   if (!native?.NativeDatabase) return;

src/features/branch-compare.ts

@@ -117,7 +117,7 @@ interface RawNodeRow {
 }
 
 /** Try opening a NativeDatabase handle for batched fan-in/fan-out metrics. */
-function openNativeDbForFanMetrics(dbPath: string): NativeDatabase | undefined {
+export function openNativeDbForFanMetrics(dbPath: string): NativeDatabase | undefined {
   if (!isNativeAvailable()) return undefined;
   try {
     const native = getNative();

tests/unit/native-db-busy-timeout-threading.test.ts

@@ -65,6 +65,11 @@ import {
 } from '../../src/db/index.js';
 import { PipelineContext } from '../../src/domain/graph/builder/context.js';
 import { reopenNativeDb } from '../../src/domain/graph/builder/stages/native-db-lifecycle.js';
+import {
+  openNativeDatabase,
+  runPostNativeAnalysis,
+} from '../../src/domain/graph/builder/stages/native-orchestrator.js';
+import { openNativeDbForFanMetrics } from '../../src/features/branch-compare.js';
 
 let tmpDir: string;
 let dbPath: string;
@@ -119,3 +124,49 @@ describe('reopenNativeDb (build pipeline) threads ctx.config.db.busyTimeoutMs in
     expect(openReadWriteCalls[0]?.[1]).toBe(CUSTOM_BUSY_TIMEOUT_MS);
   });
 });
+
+describe('openNativeDatabase (build pipeline) threads ctx.config.db.busyTimeoutMs into NativeDatabase.openReadWrite', () => {
+  it('passes ctx.config.db.busyTimeoutMs to the native factory', () => {
+    openReadWriteCalls.length = 0;
+    const ctx = new PipelineContext();
+    ctx.dbPath = dbPath;
+    ctx.db = { close: () => {} } as PipelineContext['db'];
+    ctx.nativeAvailable = true;
+    ctx.config = { db: { busyTimeoutMs: CUSTOM_BUSY_TIMEOUT_MS } } as PipelineContext['config'];
+
+    openNativeDatabase(ctx);
+
+    expect(openReadWriteCalls).toHaveLength(1);
+    expect(openReadWriteCalls[0]?.[1]).toBe(CUSTOM_BUSY_TIMEOUT_MS);
+  });
+});
+
+describe('runPostNativeAnalysis (build pipeline) threads ctx.config.db.busyTimeoutMs into NativeDatabase.openReadWrite', () => {
+  it('passes ctx.config.db.busyTimeoutMs to the native factory', async () => {
+    openReadWriteCalls.length = 0;
+    const ctx = new PipelineContext();
+    ctx.dbPath = dbPath;
+    ctx.db = openDb(dbPath);
+    ctx.rootDir = tmpDir;
+    ctx.opts = { engine: 'native' };
+    ctx.config = { db: { busyTimeoutMs: CUSTOM_BUSY_TIMEOUT_MS } } as PipelineContext['config'];
+
+    try {
+      await runPostNativeAnalysis(ctx, new Map(), []);
+    } finally {
+      closeDb(ctx.db as Parameters<typeof closeDb>[0]);
+    }
+
+    expect(openReadWriteCalls).toHaveLength(1);
+    expect(openReadWriteCalls[0]?.[1]).toBe(CUSTOM_BUSY_TIMEOUT_MS);
+  });
+});
+
+describe('openNativeDbForFanMetrics (branch-compare) threads the configured busyTimeoutMs into NativeDatabase.openReadonly', () => {
+  it('passes the configured busyTimeoutMs to the native factory', () => {
+    openReadonlyCalls.length = 0;
+    openNativeDbForFanMetrics(dbPath);
+    expect(openReadonlyCalls).toHaveLength(1);
+    expect(openReadonlyCalls[0]?.[1]).toBe(CUSTOM_BUSY_TIMEOUT_MS);
+  });
+});