refactor: widen outputResult signature, remove redundant casts at call sites

outputResult took data: Record<string, any>, whose any-typed index signature
already made TypeScript skip the "index signature is missing" check for
plain interfaces -- so callers never actually needed the defensive
`as unknown as Record<string, unknown>` cast; they just carried it forward
as noise. Widen the parameter to `object` (outputResult only serializes/
formats data and never returns or re-exposes its shape, so a generic isn't
needed) and move the one necessary cast to Record<string, unknown> inside
outputResult itself, where it's actually justified by printNdjson/printCsv/
printAutoTable needing key access for NDJSON field plucking and CSV/table
flattening. Removes the cast from all 22 current call sites across
audit.ts, triage.ts, owners.ts, and queries-cli/{impact,path,exports,
inspect,overview}.ts.

docs check acknowledged: internal type-signature cleanup only, no new
features/languages/architecture/CLI surface -- README.md, CLAUDE.md, and
ROADMAP.md do not need updates.

Fixes #1803

Impact: 23 functions changed, 79 affected

Author: carlos-alm

src/presentation/audit.ts

@@ -94,7 +94,7 @@ export function audit(
 ): void {
   const data: AuditResult = auditData(target, customDbPath, opts);
 
-  if (outputResult(data as unknown as Record<string, unknown>, null, opts)) return;
+  if (outputResult(data, null, opts)) return;
 
   if (data.functions.length === 0) {
     console.log(`No ${data.kind === 'file' ? 'file' : 'function/symbol'} matching "${target}"`);

src/presentation/owners.ts

@@ -43,7 +43,7 @@ interface OwnersResult {
 
 export function owners(customDbPath: string | undefined, opts: OwnersOpts = {}): void {
   const data = ownersData(customDbPath, opts as any) as OwnersResult;
-  if (outputResult(data as unknown as Record<string, unknown>, null, opts)) return;
+  if (outputResult(data, null, opts)) return;
 
   if (!data.codeownersFile) {
     console.log('No CODEOWNERS file found.');

src/presentation/queries-cli/exports.ts

@@ -123,7 +123,7 @@ function printReexportedSection(data: ExportsDataResult, opts: ExportsOpts): voi
 
 export function fileExports(file: string, customDbPath: string, opts: ExportsOpts = {}): void {
   const data = exportsData(file, customDbPath, opts) as ExportsDataResult;
-  if (outputResult(data as unknown as Record<string, unknown>, 'results', opts)) return;
+  if (outputResult(data, 'results', opts)) return;
 
   const hasReexported = data.reexportedSymbols && data.reexportedSymbols.length > 0;
 

src/presentation/queries-cli/impact.ts

@@ -126,7 +126,7 @@ interface OutputOpts {
 
 export function fileDeps(file: string, customDbPath: string, opts: OutputOpts = {}): void {
   const data = fileDepsData(file, customDbPath, opts) as unknown as FileDepsData;
-  if (outputResult(data as unknown as Record<string, unknown>, 'results', opts)) return;
+  if (outputResult(data, 'results', opts)) return;
 
   if (data.results.length === 0) {
     console.log(`No file matching "${file}" in graph`);
@@ -181,7 +181,7 @@ function printFnDepsTransitive(transitiveCallers: Record<string, SymbolRef[]>):
 
 export function fnDeps(name: string, customDbPath: string, opts: OutputOpts = {}): void {
   const data = fnDepsData(name, customDbPath, opts) as unknown as FnDepsData;
-  if (outputResult(data as unknown as Record<string, unknown>, 'results', opts)) return;
+  if (outputResult(data, 'results', opts)) return;
 
   if (data.results.length === 0) {
     console.log(`No function/method/class matching "${name}"`);
@@ -202,7 +202,7 @@ export function fnDeps(name: string, customDbPath: string, opts: OutputOpts = {}
 
 export function impactAnalysis(file: string, customDbPath: string, opts: OutputOpts = {}): void {
   const data = impactAnalysisData(file, customDbPath, opts) as unknown as ImpactData;
-  if (outputResult(data as unknown as Record<string, unknown>, 'sources', opts)) return;
+  if (outputResult(data, 'sources', opts)) return;
 
   if (data.sources.length === 0) {
     console.log(`No file matching "${file}" in graph`);
@@ -231,7 +231,7 @@ export function impactAnalysis(file: string, customDbPath: string, opts: OutputO
 
 export function fnImpact(name: string, customDbPath: string, opts: OutputOpts = {}): void {
   const data = fnImpactData(name, customDbPath, opts) as unknown as FnImpactData;
-  if (outputResult(data as unknown as Record<string, unknown>, 'results', opts)) return;
+  if (outputResult(data, 'results', opts)) return;
 
   if (data.results.length === 0) {
     console.log(`No function/method/class matching "${name}"`);
@@ -302,7 +302,7 @@ export function diffImpact(customDbPath: string, opts: OutputOpts = {}): void {
   }
   const data = diffImpactData(customDbPath, opts) as unknown as DiffImpactData;
   if (opts.format === 'json') opts = { ...opts, json: true };
-  if (outputResult(data as unknown as Record<string, unknown>, 'affectedFunctions', opts)) return;
+  if (outputResult(data, 'affectedFunctions', opts)) return;
 
   if (data.error) {
     console.log(data.error);

src/presentation/queries-cli/inspect.ts

@@ -222,7 +222,7 @@ function renderWhereFileResults(results: WhereFileResult[]): void {
 
 export function where(target: string, customDbPath: string, opts: OutputOpts = {}): void {
   const data = whereData(target, customDbPath, opts as Record<string, unknown>) as WhereData;
-  if (outputResult(data as unknown as Record<string, unknown>, 'results', opts)) return;
+  if (outputResult(data, 'results', opts)) return;
 
   if (data.results.length === 0) {
     console.log(
@@ -247,7 +247,7 @@ export function queryName(name: string, customDbPath: string, opts: OutputOpts =
     limit: opts.limit,
     offset: opts.offset,
   }) as QueryNameData;
-  if (outputResult(data as unknown as Record<string, unknown>, 'results', opts)) return;
+  if (outputResult(data, 'results', opts)) return;
 
   if (data.results.length === 0) {
     console.log(`No results for "${name}"`);
@@ -275,7 +275,7 @@ export function queryName(name: string, customDbPath: string, opts: OutputOpts =
 
 export function context(name: string, customDbPath: string, opts: OutputOpts = {}): void {
   const data = contextData(name, customDbPath, opts as Record<string, unknown>) as ContextData;
-  if (outputResult(data as unknown as Record<string, unknown>, 'results', opts)) return;
+  if (outputResult(data, 'results', opts)) return;
 
   if (data.results.length === 0) {
     console.log(`No function/method/class matching "${name}"`);
@@ -289,7 +289,7 @@ export function context(name: string, customDbPath: string, opts: OutputOpts = {
 
 export function children(name: string, customDbPath: string, opts: OutputOpts = {}): void {
   const data = childrenData(name, customDbPath, opts as Record<string, unknown>) as ChildrenData;
-  if (outputResult(data as unknown as Record<string, unknown>, 'results', opts)) return;
+  if (outputResult(data, 'results', opts)) return;
 
   if (data.results.length === 0) {
     console.log(`No symbol matching "${name}"`);
@@ -505,7 +505,7 @@ function renderFunctionExplain(r: FunctionExplainResult, indent = ''): void {
 
 export function explain(target: string, customDbPath: string, opts: OutputOpts = {}): void {
   const data = explainData(target, customDbPath, opts as Record<string, unknown>) as ExplainData;
-  if (outputResult(data as unknown as Record<string, unknown>, 'results', opts)) return;
+  if (outputResult(data, 'results', opts)) return;
 
   if (data.results.length === 0) {
     console.log(`No ${data.kind === 'file' ? 'file' : 'function/symbol'} matching "${target}"`);
@@ -529,7 +529,7 @@ export function implementations(name: string, customDbPath: string, opts: Output
     customDbPath,
     opts as Record<string, unknown>,
   ) as ImplementationsData;
-  if (outputResult(data as unknown as Record<string, unknown>, 'results', opts)) return;
+  if (outputResult(data, 'results', opts)) return;
 
   if (data.results.length === 0) {
     console.log(`No symbol matching "${name}"`);
@@ -556,7 +556,7 @@ export function interfaces(name: string, customDbPath: string, opts: OutputOpts
     customDbPath,
     opts as Record<string, unknown>,
   ) as InterfacesData;
-  if (outputResult(data as unknown as Record<string, unknown>, 'results', opts)) return;
+  if (outputResult(data, 'results', opts)) return;
 
   if (data.results.length === 0) {
     console.log(`No symbol matching "${name}"`);

src/presentation/queries-cli/overview.ts

@@ -262,7 +262,7 @@ export async function stats(customDbPath: string, opts: OutputOpts = {}): Promis
     debug(`stats: community detection failed (optional): ${toErrorMessage(e)}`);
   }
 
-  if (outputResult(data as unknown as Record<string, unknown>, null, opts)) return;
+  if (outputResult(data, null, opts)) return;
 
   console.log('\n# Codegraph Stats\n');
   printNodes(data);
@@ -280,7 +280,7 @@ export async function stats(customDbPath: string, opts: OutputOpts = {}): Promis
 
 export function moduleMap(customDbPath: string, limit = 20, opts: OutputOpts = {}): void {
   const data = moduleMapData(customDbPath, limit, { noTests: opts.noTests }) as ModuleMapData;
-  if (outputResult(data as unknown as Record<string, unknown>, 'topNodes', opts)) return;
+  if (outputResult(data, 'topNodes', opts)) return;
 
   console.log(`\nModule map (top ${limit} most-connected nodes):\n`);
   const dirs = new Map<string, TopNode[]>();
@@ -326,11 +326,7 @@ function printRoleGroup(role: string, symbols: RoleSymbol[]): void {
 export function dynamicCalls(customDbPath: string, opts: OutputOpts = {}): void {
   const rows = dynamicCallsData(customDbPath);
   if (opts.json || opts.ndjson) {
-    outputResult(
-      { dynamic_calls: rows } as unknown as Record<string, unknown>,
-      'dynamic_calls',
-      opts,
-    );
+    outputResult({ dynamic_calls: rows }, 'dynamic_calls', opts);
     return;
   }
   if (rows.length === 0) {
@@ -353,7 +349,7 @@ export function dynamicCalls(customDbPath: string, opts: OutputOpts = {}): void
 
 export function roles(customDbPath: string, opts: OutputOpts = {}): void {
   const data = rolesData(customDbPath, opts) as RolesData;
-  if (outputResult(data as unknown as Record<string, unknown>, 'symbols', opts)) return;
+  if (outputResult(data, 'symbols', opts)) return;
 
   if (data.count === 0) {
     console.log('No classified symbols found. Run "codegraph build" first.');

src/presentation/queries-cli/path.ts

@@ -86,7 +86,7 @@ export function symbolPath(
   }
 
   const data = pathData(from, to, customDbPath, opts) as PathDataResult;
-  if (outputResult(data as unknown as Record<string, unknown>, null, opts)) return;
+  if (outputResult(data, null, opts)) return;
 
   if (data.error) {
     console.log(data.error);
@@ -160,7 +160,7 @@ function printFilePathSteps(data: FilePathDataResult): void {
 
 function filePath(from: string, to: string, customDbPath: string, opts: PathOpts = {}): void {
   const data = filePathData(from, to, customDbPath, opts) as FilePathDataResult;
-  if (outputResult(data as unknown as Record<string, unknown>, null, opts)) return;
+  if (outputResult(data, null, opts)) return;
 
   if (data.error) {
     console.log(data.error);

src/presentation/result-formatter.ts

@@ -132,17 +132,18 @@ export interface OutputOpts {
   display?: DisplayOpts;
 }
 
-export function outputResult(
-  data: Record<string, any>,
-  field: string | null,
-  opts: OutputOpts,
-): boolean {
+export function outputResult(data: object, field: string | null, opts: OutputOpts): boolean {
+  // The formatting helpers below need key/index access (NDJSON field pluck, CSV/table
+  // flattening). Callers only ever hand off a concrete result shape for serialization,
+  // so the cast lives here once instead of as a defensive `as unknown as Record<...>`
+  // at every call site.
+  const record = data as Record<string, unknown>;
   if (opts.ndjson) {
     if (field === null) {
       // No field key — emit the whole object as a single NDJSON line
       console.log(JSON.stringify(data));
     } else {
-      printNdjson(data, field);
+      printNdjson(record, field);
     }
     return true;
   }
@@ -151,11 +152,11 @@ export function outputResult(
     return true;
   }
   if (opts.csv) {
-    return printCsv(data, field) !== false;
+    return printCsv(record, field) !== false;
   }
   if (opts.table) {
     const displayOpts = opts.display ?? (loadConfig() as { display: DisplayOpts }).display;
-    return printAutoTable(data, field, displayOpts) !== false;
+    return printAutoTable(record, field, displayOpts) !== false;
   }
   return false;
 }

src/presentation/triage.ts

@@ -42,7 +42,7 @@ export function triage(customDbPath: string | undefined, opts: TriageOpts = {}):
     summary: TriageSummary;
   };
 
-  if (outputResult(data as unknown as Record<string, unknown>, 'items', opts)) return;
+  if (outputResult(data, 'items', opts)) return;
 
   if (data.items.length === 0) {
     if (data.summary.total === 0) {