Commit ec4f102
authored
fix(audit): distinguish "file not found" from "file has zero functions" (#2142)
* fix(audit): distinguish "file not found" from "file has zero functions"
codegraph audit <file> printed the same "No file matching" message for
a file that genuinely isn't in the graph and for a real, tracked file
that just has zero own function/method/class definitions (e.g. a pure
re-export barrel) — misleadingly implying the graph doesn't know about
a file it actually parsed correctly.
Adds AuditResult.found, set to false only when explainData finds zero
matching file/symbol entries at all; presentation/audit.ts now renders
a distinct message when found !== false but functions is still empty.
Closes #2135
Impact: 3 functions changed, 3 affected
* fix: base found flag on pre-filter results to avoid false negatives (#2142)
auditData set found: false using the post `--file`/`--kind` filtered
results array, so a function that genuinely exists in the graph but is
filtered out entirely by those options was misreported as "not found" --
the exact bug this PR set out to fix, reachable via a different input
shape. Check explained.results (pre-filter) instead.
Impact: 1 functions changed, 3 affected1 parent 08644a1 commit ec4f102
4 files changed
Lines changed: 52 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
162 | 162 | | |
163 | 163 | | |
164 | 164 | | |
165 | | - | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
| 176 | + | |
166 | 177 | | |
167 | 178 | | |
168 | 179 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
97 | 97 | | |
98 | 98 | | |
99 | 99 | | |
100 | | - | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
101 | 105 | | |
102 | 106 | | |
103 | 107 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1731 | 1731 | | |
1732 | 1732 | | |
1733 | 1733 | | |
| 1734 | + | |
| 1735 | + | |
| 1736 | + | |
| 1737 | + | |
| 1738 | + | |
1734 | 1739 | | |
1735 | 1740 | | |
1736 | 1741 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
63 | 63 | | |
64 | 64 | | |
65 | 65 | | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
66 | 69 | | |
67 | 70 | | |
68 | 71 | | |
| |||
258 | 261 | | |
259 | 262 | | |
260 | 263 | | |
| 264 | + | |
| 265 | + | |
| 266 | + | |
| 267 | + | |
| 268 | + | |
| 269 | + | |
| 270 | + | |
| 271 | + | |
| 272 | + | |
| 273 | + | |
| 274 | + | |
| 275 | + | |
| 276 | + | |
| 277 | + | |
| 278 | + | |
| 279 | + | |
| 280 | + | |
| 281 | + | |
| 282 | + | |
| 283 | + | |
| 284 | + | |
| 285 | + | |
| 286 | + | |
| 287 | + | |
| 288 | + | |
| 289 | + | |
| 290 | + | |
261 | 291 | | |
262 | 292 | | |
263 | 293 | | |
| |||
0 commit comments