fix(cha): add self-loop guard to runPostNativeCha and TODO for confidence alignment (#1514)

runPostNativeCha's BFS inner loop was missing the same self-loop guard
already added to runChaPostPass and runPostNativeThisDispatch, allowing
B.m→B.m edges to persist on the native CHA path when super-dispatch
triggers CHA expansion. Also adds a TODO comment on the hardcoded 0.8
confidence in runChaPostPass noting it needs alignment with the formula
used in runPostNativeCha (requires extending findMethodStmt to fetch file).

Author: carlos-alm

src/domain/graph/builder/helpers.ts

@@ -515,7 +515,7 @@ export function runChaPostPass(db: BetterSqlite3Database): number {
             const key = `${source_id}|${methodNode.id}`;
             if (seen.has(key)) continue;
             seen.add(key);
-            newEdges.push([source_id, methodNode.id, 'calls', 0.8, 0, 'cha']);
+            newEdges.push([source_id, methodNode.id, 'calls', 0.8, 0, 'cha']); // TODO: align with runPostNativeCha: computeConfidence(callerFile, methodFile) - CHA_DISPATCH_PENALTY (requires extending findMethodStmt to fetch file)
           }
         }
 

src/domain/graph/builder/stages/native-orchestrator.ts

@@ -654,6 +654,7 @@ function runPostNativeCha(
             method_file: string | null;
           }>;
           for (const methodNode of methodNodes) {
+            if (methodNode.id === source_id) continue; // skip self-loops
             const key = `${source_id}|${methodNode.id}`;
             if (seen.has(key)) continue;
             seen.add(key);