Skip to content

fix(test): use --experimental-strip-types in Worker execArgv #1164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
carlos-alm merged 3 commits into from
May 19, 2026
Merged

fix(test): use --experimental-strip-types in Worker execArgv #1164

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d708610
fix(test): use --experimental-strip-types in Worker execArgv
carlos-alm May 19, 2026
5a3de60
Merge branch 'main' into fix/1117-snapshot-worker-strip-types
carlos-alm May 19, 2026
270bb8f
Merge branch 'main' into fix/1117-snapshot-worker-strip-types
carlos-alm May 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions tests/unit/snapshot.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,16 +149,16 @@ describe('snapshotSave', () => {
// snapshotSave. better-sqlite3 is synchronous, so Promise-based
// concurrency would queue two sequential microtasks — only separate
// threads exercise the TOCTOU race.
const nodeMajor = Number(process.versions.node.split('.')[0]);
const raceWorkerPath = path.join(__dirname, 'snapshot-race-worker.mjs');
// --import requires a URL (file://…) or a bare/relative specifier, not a
// drive-letter path on Windows. Use the file:// URL directly.
const loaderUrl = new URL('../../scripts/ts-resolve-loader.js', import.meta.url).href;
const raceExecArgv = [
nodeMajor >= 23 ? '--strip-types' : '--experimental-strip-types',
'--import',
loaderUrl,
];
// `--experimental-strip-types` is accepted by Worker execArgv across all
// supported Node versions (≥ 22.6); the unprefixed `--strip-types` flag
// is not in the Worker allowlist on Node 24 and causes
// ERR_WORKER_INVALID_EXEC_ARGV. On Node ≥ 23.6 type stripping is on by
// default, so the flag is a harmless no-op there.
const raceExecArgv = ['--experimental-strip-types', '--import', loaderUrl];
const spawnSaveWorker = (workerData: {
dbPath: string;
name: string;
Expand Down
Loading