-
Notifications
You must be signed in to change notification settings - Fork 13
test(jelly-micro): add per-fixture recall floors #1409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
b7553ca
test(jelly-micro): add per-fixture recall floors
carlos-alm 48aeea8
test(jelly-micro): validate RECALL_FLOORS keys against discovered fix…
carlos-alm db459d5
fix: resolve merge conflicts with main
carlos-alm ef9a741
Merge branch 'main' into test/jelly-micro-recall-floors-1387
carlos-alm 88a374d
fix(jelly-micro): remove stale more1 entry from RECALL_FLOORS
carlos-alm adc1f04
Merge remote-tracking branch 'origin/test/jelly-micro-recall-floors-1…
carlos-alm d6c568f
fix(jelly-micro): correct classes floor from 0.2 to 0.19 (6/31, not 6…
carlos-alm 2abb560
Merge remote-tracking branch 'origin/test/jelly-micro-recall-floors-1…
carlos-alm fdc857b
Merge branch 'main' into test/jelly-micro-recall-floors-1387
carlos-alm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RECALL_FLOORSentries that don't match any discovered fixture name are silently ignored — the affected test would fall back tofloor = 0instead of the intended floor. If a fixture directory is renamed (e.g.super→super-v2) or a key is mistyped here, the regression protection is lost without any warning. Adding a quick sanity check afterdiscoverTests()— verifying everyObject.keys(RECALL_FLOORS)entry appears intests— would catch this at suite startup rather than silently lowering the bar.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed — added a startup sanity-check after
discoverTests()that throws if any key inRECALL_FLOORSdoes not match a discovered fixture directory. Gated ontests.length > 0so it does not fire in CI environments where the jelly-micro directory is gitignored (the suite is skipped there anyway).