-
Notifications
You must be signed in to change notification settings - Fork 13
chore(skills): review README and repo about text on every release #1429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
7e862f4
chore(skills): review README and repo about text on every release
carlos-alm 1a69fac
fix(skills): reinforce PUT /topics full-replace semantics and add abo…
carlos-alm 246fec3
Merge branch 'main' into chore/release-skill-about-text
carlos-alm 6db4d11
Merge branch 'main' into chore/release-skill-about-text
carlos-alm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PUT /repos/{owner}/{repo}/topicsreplaces the complete topics list atomically. The inline note says "replaces the full list — include all desired topics," but the example command only enumerates four topics. An agent that uses the example as a near-literal template (rather than building the list from the fetched topics in the earliergh apicall) would silently drop any topics not in that hardcoded example. Prefacing the command with an explicit instruction to start from the fetched list — e.g., "Merge the fetched topics with any additions/removals before running the PUT; do not rely on the example list below" — would prevent accidental topic loss.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed — added two comment lines before the PUT example making the full-replace semantics explicit: 'start from the fetched list above, then add/remove as needed' and 'This PUT replaces ALL topics atomically; do NOT copy the example below verbatim — build the full list from the currently active topics first, then adjust.'