Skip to content

Commit 46e9286

Browse files
committed
add clarifying comment for a test
1 parent 154af9a commit 46e9286

2 files changed

Lines changed: 4 additions & 3 deletions

File tree

pkg/optimizely/optimizelytest/config.go

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -523,12 +523,14 @@ func (c *TestProjectConfig) GetFlagVariationsMap() map[string][]entities.Variati
523523
return c.flagVariationsMap
524524
}
525525

526-
// GetHoldoutList returns an array of all holdouts
526+
// GetHoldoutList returns an array of all holdouts in the project
527527
func (c *TestProjectConfig) GetHoldoutList() []entities.Holdout {
528528
return []entities.Holdout{}
529529
}
530530

531-
// GetHoldoutsForFlag returns all holdouts applicable to the given feature flag
531+
// GetHoldoutsForFlag returns all holdouts applicable to the given feature flag.
532+
// In production, this would return a filtered list based on the flag's includedFlags/excludedFlags.
533+
// For this test mock, we return an empty list since no tests currently require holdout logic.
532534
func (c *TestProjectConfig) GetHoldoutsForFlag(featureKey string) []entities.Holdout {
533535
return []entities.Holdout{}
534536
}

tests/acceptance/test_acceptance/test_config.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55

66
from tests.acceptance.helpers import ENDPOINT_CONFIG
77
from tests.acceptance.helpers import create_and_validate_request_and_response
8-
from tests.acceptance.holdouts_datafile import holdouts_datafile
98

109
expected_config = """{
1110
"environmentKey": "production",

0 commit comments

Comments
 (0)