Conversation
muzahidul-opti
approved these changes
Oct 30, 2025
Contributor
muzahidul-opti
left a comment
muzahidul-opti
left a comment
There was a problem hiding this comment.
The changes look well-structured and streamlined dependency management.
One suggestion: Can we ensure the ship task is working fine, so that there would be no issue when releasing the SDK.
pvcraven
approved these changes
Oct 30, 2025
Contributor
Author
Yes, I'll try to release it to check ship. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrade targetSDKVersion = 35 as required by google.
Upgrade gradle and AGP versions as well to support the new targetSDKVersion.
Test plan
No new test cases
Issues