[FSSDK-11837] legacy api adjustment with key null support in decide#388
Merged
junaed-optimizely merged 3 commits intomasterfrom Sep 4, 2025
Merged
[FSSDK-11837] legacy api adjustment with key null support in decide#388junaed-optimizely merged 3 commits intomasterfrom
junaed-optimizely merged 3 commits intomasterfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This pull request improves error handling in the Optimizely SDK by adding validation for null flag keys in the Decide method. When a null flag key is passed, the method now returns a proper error decision with a specific error message instead of potentially causing downstream issues.
- Added null check validation in the
Decidemethod to return an error decision for null flag keys - Added unit test to verify the new null flag key validation behavior
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| OptimizelySDK/Optimizely.cs | Added null check for flag key parameter in Decide method with proper error handling |
| OptimizelySDK.Tests/OptimizelyUserContextTest.cs | Added unit test to verify null flag key returns expected error decision |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
mikechu-optimizely
approved these changes
Sep 4, 2025
Contributor
mikechu-optimizely
left a comment
There was a problem hiding this comment.
I agree with the check for key equals null check and the supporting unit test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request adds a new validation for null flag keys in the decision logic, ensuring that passing a null flag key to the
Decidemethod returns a proper error decision. It also introduces a corresponding unit test to verify this behavior.Error handling improvements:
Optimizely.csto return an error decision if the flag key passed toDecideis null, using a specific error message (FLAG_KEY_INVALID).Testing enhancements:
DecideNullFlagKey, inOptimizelyUserContextTest.csto verify that passing a null flag key returns the expected error decision.Issues
FSSDK-11837