[FSSDK-11168] feat: add cmab service #393
Merged
junaed-optimizely merged 5 commits intomasterfrom Oct 10, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new CMAB (Contextual Multi-Armed Bandit) service for the Optimizely SDK that handles decision-making and cache management. The implementation provides intelligent caching based on user attributes with cache invalidation options.
Key changes:
- Added ICmabService interface and DefaultCmabService implementation with attribute-based caching
- Extended OptimizelyDecideOption enum with three new CMAB cache control options
- Comprehensive test coverage for the new CMAB service functionality
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| OptimizelySDK.csproj | Added compilation entries for new CMAB service files |
| OptimizelyDecideOption.cs | Added cache control options for CMAB decisions |
| ICmabService.cs | Defined interface contract for CMAB decision services |
| DefaultCmabService.cs | Implemented full CMAB service with caching and attribute filtering |
| OptimizelySDK.Tests.csproj | Added test file compilation entry |
| DefaultCmabServiceTest.cs | Comprehensive test suite covering all CMAB service functionality |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
muzahidul-opti
left a comment
muzahidul-opti
left a comment
There was a problem hiding this comment.
Changes look good to me, added a couple of commnets
muzahidul-opti
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CMAB service addition which is responsible for decision-making and cache management in the CMAB (Contextual Multi-Armed Bandit) feature.
Test Plan
Tests have been added to support the implementation
Issues
FSSDK-11168