[FSSDK-12813] Remove ticket references from code comments per cross-sdk guideline

Author: jaeopt

pkg/event/event_id_normalizer.go

@@ -17,14 +17,14 @@
 // Package event //
 package event
 
-// Decision event ID normalization (FSSDK-12813).
+// Decision event ID normalization.
 //
 // These helpers normalize the campaign_id, variation_id, and entity_id fields
 // of outgoing decision events so that every decision type (experiment, feature
 // test, rollout, holdout) produces uniform, valid wire output regardless of
 // what upstream code supplies.
 //
-// Contract (per relaxed FSSDK-12813 spec):
+// Contract:
 //   - campaign_id / entity_id: must be a non-empty string. Any character
 //     content is allowed (IDs may be opaque, e.g. "default-12345", "layer_abc").
 //     When the value is empty (""), fall back to experiment_id.
@@ -68,10 +68,10 @@ func IsNonEmptyString(value string) bool {
 }
 
 // NormalizeCampaignID returns campaignID if it is a non-empty string;
-// otherwise it returns experimentID. Per the relaxed FSSDK-12813 spec, any
-// non-empty character content is accepted for campaign_id / entity_id —
-// IDs may be opaque (e.g. "default-12345", "layer_abc"). Fallback to
-// experiment_id fires ONLY when campaignID is the empty string.
+// otherwise it returns experimentID. Any non-empty character content is
+// accepted for campaign_id / entity_id — IDs may be opaque (e.g.
+// "default-12345", "layer_abc"). Fallback to experiment_id fires ONLY when
+// campaignID is the empty string.
 //
 // This function is used for both decisions[].campaign_id and (for impression
 // events) events[].entity_id so both fields are normalized identically and

pkg/event/event_id_normalizer_test.go

@@ -28,10 +28,9 @@ import (
 	"github.com/optimizely/go-sdk/v2/pkg/entities"
 )
 
-// FSSDK-12813: Decision-event ID normalization tests.
+// Decision-event ID normalization tests.
 //
-// These tests verify the cross-SDK contract for outgoing decision events
-// (per the relaxed spec):
+// These tests verify the cross-SDK contract for outgoing decision events:
 //   - campaign_id / entity_id: non-empty string (any character content;
 //     opaque IDs allowed). Fallback to experiment_id ONLY when empty.
 //   - variation_id: STRICT non-empty numeric string OR JSON null.
@@ -262,8 +261,8 @@ func numericVariation() entities.Variation {
 }
 
 func holdoutExperiment() entities.Experiment {
-	// FSSDK-12813: Holdouts ship with no LayerID. Normalizer must fall back
-	// to ExperimentID for both campaign_id and entity_id.
+	// Holdouts ship with no LayerID. Normalizer must fall back to
+	// ExperimentID for both campaign_id and entity_id.
 	return entities.Experiment{Key: "holdout_key", LayerID: "", ID: "9876543210"}
 }
 
@@ -280,10 +279,10 @@ func TestImpressionEvent_NormalizesCampaignAndEntityIDsForHoldout(t *testing.T)
 
 	// FR-001/FR-002: empty LayerID is substituted with ExperimentID.
 	assert.Equal(t, exp.ID, userEvent.Impression.CampaignID,
-		"holdout campaign_id must fall back to experiment_id when LayerID is empty (FSSDK-12813)")
+		"holdout campaign_id must fall back to experiment_id when LayerID is empty")
 	// FR-009: entity_id mirrors campaign_id byte-for-byte.
 	assert.Equal(t, exp.ID, userEvent.Impression.EntityID,
-		"holdout entity_id must equal campaign_id byte-for-byte (FSSDK-12813)")
+		"holdout entity_id must equal campaign_id byte-for-byte")
 
 	// Same invariant must hold in the wire visitor / decision payload.
 	visitor := createVisitorFromUserEvent(userEvent)
@@ -313,7 +312,7 @@ func TestImpressionEvent_PassesThroughOpaqueLayerID(t *testing.T) {
 	// Opaque LayerID passes through under the relaxed spec — NOT substituted
 	// with experiment_id.
 	assert.Equal(t, "default-12345", userEvent.Impression.CampaignID,
-		"opaque LayerID must pass through (FSSDK-12813 relaxed)")
+		"opaque LayerID must pass through (relaxed contract)")
 	assert.Equal(t, "default-12345", userEvent.Impression.EntityID,
 		"entity_id must mirror campaign_id (FR-009)")
 
@@ -356,7 +355,7 @@ func TestImpressionEvent_NormalizesVariationIDToJSONNull(t *testing.T) {
 
 	visitor := createVisitorFromUserEvent(userEvent)
 	assert.Nil(t, visitor.Snapshots[0].Decisions[0].VariationID,
-		"non-numeric variation_id must be normalized to nil so it serializes as JSON null (FSSDK-12813)")
+		"non-numeric variation_id must be normalized to nil so it serializes as JSON null")
 
 	// Verify on-the-wire JSON shape.
 	b, err := json.Marshal(visitor.Snapshots[0].Decisions[0])

pkg/event/events.go

@@ -116,8 +116,8 @@ type Snapshot struct {
 //
 // VariationID is a pointer so that an empty / non-numeric upstream value
 // can be serialized as JSON null per the cross-SDK decision-event
-// normalization spec (FSSDK-12813). A nil VariationID marshals to
-// "variation_id": null on the wire.
+// normalization spec. A nil VariationID marshals to "variation_id": null
+// on the wire.
 type Decision struct {
 	VariationID  *string          `json:"variation_id"`
 	CampaignID   string           `json:"campaign_id"`

pkg/event/events_test.go

@@ -24,7 +24,7 @@ import (
 )
 
 func TestSnapshotHasOptionalDecisions(t *testing.T) {
-	// FSSDK-12813: Decision.VariationID is *string so that an empty / non-numeric
+	// Decision.VariationID is *string so that an empty / non-numeric
 	// upstream value can serialize as JSON null. Pass &v with a numeric ID.
 	v := "1"
 	snapshot := Snapshot{

pkg/event/factory.go

@@ -103,16 +103,8 @@ func createImpressionEvent(
 		variationID = variation.ID
 	}
 
-	// FSSDK-12813: Normalize campaign_id, variation_id, and entity_id uniformly
-	// for every decision type (experiment, feature test, rollout, holdout).
-	// - campaign_id falls back to experiment.ID when LayerID is the empty
-	//   string (e.g. holdouts have no layer). Any non-empty value — numeric
-	//   or opaque (e.g. "layer_abc") — passes through per the relaxed spec.
-	// - entity_id mirrors the normalized campaign_id so both fields are
-	//   byte-equivalent on the wire (FR-009).
-	// - variation_id is normalized later when the Decision is built, since the
-	//   Decision struct uses *string to allow JSON null output (FR-003/FR-004).
-	//   variation_id retains the STRICT numeric-string contract.
+	// entity_id mirrors the normalized campaign_id so both fields are
+	// byte-equivalent on the wire.
 	normalizedCampaignID := NormalizeCampaignID(experiment.LayerID, experiment.ID)
 
 	event := ImpressionEvent{
@@ -186,12 +178,9 @@ func CreateImpressionUserEvent(
 
 // create an impression visitor
 func createImpressionVisitor(userEvent UserEvent) Visitor {
-	// FSSDK-12813: Apply decision-event ID normalization at the visitor /
-	// wire-payload boundary as a defense-in-depth pass. The ImpressionEvent
-	// is already normalized when constructed (see createImpressionEvent), but
-	// normalizing again here guarantees that any callers who mutate the
-	// in-memory ImpressionEvent before dispatch still produce a valid wire
-	// payload. This call is idempotent for already-normalized values.
+	// Re-normalize at the wire-payload boundary as defense-in-depth so
+	// callers that mutate the ImpressionEvent before dispatch still produce
+	// a valid payload. Idempotent for already-normalized values.
 	normalizedCampaignID := NormalizeCampaignID(userEvent.Impression.CampaignID, userEvent.Impression.ExperimentID)
 
 	decision := Decision{}

pkg/event/factory_test.go

@@ -339,12 +339,8 @@ func TestCreateImpressionUserEventWithCmabUUID(t *testing.T) {
 func TestCreateImpressionUserEventForHoldout(t *testing.T) {
 	tc := TestConfig{}
 
-	// FSSDK-12813: variation_id retains a strict numeric-string contract on
-	// the wire (non-numeric values serialize as JSON null). campaign_id /
-	// entity_id are relaxed to non-empty strings (opaque IDs allowed; the
-	// only fallback to experiment_id is when LayerID is the empty string).
-	// Use numeric IDs in fixtures so the happy-path assertions below exercise
-	// both the variation_id pass-through and the empty-LayerID fallback for
+	// Use numeric IDs in fixtures so the assertions below exercise the
+	// variation_id pass-through and the empty-LayerID fallback for
 	// campaign_id without entanglement.
 	testHoldout := entities.Experiment{
 		Key:     "test_holdout",
@@ -447,9 +443,8 @@ func TestCreateImpressionUserEventForHoldout(t *testing.T) {
 		// Verify IDs are set correctly
 		assert.Equal(t, testHoldoutVariation.ID, impression.VariationID)
 		assert.Equal(t, testHoldout.ID, impression.ExperimentID)
-		// FSSDK-12813: Holdouts have no LayerID, so the impression's CampaignID
-		// is normalized to ExperimentID (FR-001/FR-002). The same normalized
-		// value is also reused as the impression's EntityID (FR-009).
+		// Holdouts have no LayerID, so the impression's CampaignID is
+		// normalized to ExperimentID. EntityID mirrors CampaignID.
 		assert.Equal(t, testHoldout.ID, impression.CampaignID)
 		assert.Equal(t, testHoldout.ID, impression.EntityID)
 	})