[FSSDK-11169] Implement Decision Service methods to handle CMAB#403
Merged
Mat001 merged 19 commits intoJun 6, 2025
Conversation
bccad3d to
b8f9e9c
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR implements support for CMAB decision making in the Decision Service by adding new CMAB methods, updating relevant entities and reasons, and integrating the CMAB service into the composite experiment service.
- Added experiment_cmab_service.go with CMAB-related decision logic
- Updated reason constants and entities to include CMAB support
- Integrated CMAB decision service in the composite experiment service and added corresponding unit tests
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/decision/reasons/reason.go | Added new constant CmabVariationAssigned for CMAB decisions |
| pkg/decision/experiment_cmab_service_test.go | Introduced unit tests for various CMAB decision scenarios |
| pkg/decision/experiment_cmab_service.go | Implemented the CMAB decision logic and error handling |
| pkg/decision/entities.go | Updated entities to register the new Cmab Source |
| pkg/decision/composite_experiment_service.go | Extended composite service to include CMAB service integration |
Comments suppressed due to low confidence (1)
pkg/decision/reasons/reason.go:63
- [nitpick] The string value for CmabVariationAssigned is inconsistent with the format of other reason constants. Consider using a consistent, human-readable format (e.g. "CMAB variation assigned") to improve clarity.
CmabVariationAssigned Reason = "cmab_variation_assigned"
raju-opti
requested changes
May 23, 2025
raju-opti
requested changes
Jun 2, 2025
raju-opti
approved these changes
Jun 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Decision Service methods to handle CMAB
Added unit tests.
Jira ticket: https://jira.sso.episerver.net/browse/FSSDK-11169