Skip to content

Commit 0f3eb8e

Browse files
committed
fix per review
1 parent 9670cc3 commit 0f3eb8e

File tree

1 file changed

+5
-13
lines changed

1 file changed

+5
-13
lines changed

core-api/src/main/java/com/optimizely/ab/config/DatafileProjectConfig.java

Lines changed: 5 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -375,24 +375,16 @@ private List<Experiment> injectFeatureRolloutVariations(
375375
return allExperiments;
376376
}
377377

378-
// Build rollout ID to Rollout mapping
379-
Map<String, Rollout> rolloutMap = new HashMap<>();
380-
if (rollouts != null) {
381-
for (Rollout rollout : rollouts) {
382-
rolloutMap.put(rollout.getId(), rollout);
383-
}
384-
}
385-
386378
// Build experiment ID to index mapping for quick lookup
387379
Map<String, Integer> experimentIndexMap = new HashMap<>();
388380
for (int i = 0; i < allExperiments.size(); i++) {
389381
experimentIndexMap.put(allExperiments.get(i).getId(), i);
390382
}
391383

392-
List<Experiment> result = new ArrayList<>(allExperiments);
384+
List<Experiment> updatedExperiments = new ArrayList<>(allExperiments);
393385

394386
for (FeatureFlag flag : featureFlags) {
395-
Variation everyoneElseVariation = getEveryoneElseVariation(flag, rolloutMap);
387+
Variation everyoneElseVariation = getEveryoneElseVariation(flag, this.rolloutIdMapping);
396388
if (everyoneElseVariation == null) {
397389
continue;
398390
}
@@ -402,7 +394,7 @@ private List<Experiment> injectFeatureRolloutVariations(
402394
if (index == null) {
403395
continue;
404396
}
405-
Experiment experiment = result.get(index);
397+
Experiment experiment = updatedExperiments.get(index);
406398
if (!Experiment.TYPE_FR.equals(experiment.getType())) {
407399
continue;
408400
}
@@ -429,11 +421,11 @@ private List<Experiment> injectFeatureRolloutVariations(
429421
experiment.getType()
430422
);
431423

432-
result.set(index, updatedExperiment);
424+
updatedExperiments.set(index, updatedExperiment);
433425
}
434426
}
435427

436-
return result;
428+
return updatedExperiments;
437429
}
438430

439431
/**

0 commit comments

Comments
 (0)