Skip to content

Commit 359f658

Browse files
test update
1 parent aa3ca41 commit 359f658

1 file changed

Lines changed: 8 additions & 2 deletions

File tree

lib/utils/http_request_handler/request_handler.node.spec.ts

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,8 @@ import nock from 'nock';
2121
import zlib from 'zlib';
2222
import { NodeRequestHandler } from './request_handler.node';
2323
import { getMockLogger } from '../../tests/mock/mock_logger';
24+
import { OptimizelyError } from '../../error/optimizly_error';
25+
import { INVALID_REQUEST_URL } from 'error_message';
2426

2527
beforeAll(() => {
2628
nock.disableNetConnect();
@@ -174,9 +176,13 @@ describe('NodeRequestHandler', () => {
174176
});
175177

176178
it('should return a rejected response promise when the URL is malformed', async () => {
177-
const request = nodeRequestHandler.makeRequest('not a valid url', {}, 'get');
179+
const malformedUrl = 'not a valid url';
180+
const request = nodeRequestHandler.makeRequest(malformedUrl, {}, 'get');
178181

179-
await expect(request.responsePromise).rejects.toThrow();
182+
const error = await request.responsePromise.catch((e) => e);
183+
expect(error).toBeInstanceOf(OptimizelyError);
184+
expect(error.baseMessage).toBe(INVALID_REQUEST_URL);
185+
expect(error.params).toEqual([malformedUrl]);
180186
});
181187

182188
it('should return a rejected promise when there is a request error', async () => {

0 commit comments

Comments
 (0)