[FSSDK-12813] Remove ticket references from code comments per cross-sdk guideline

Author: jaeopt

lib/event_processor/event_builder/log_event.spec.ts

@@ -26,9 +26,8 @@ import { Region } from '../../project_config/project_config';
 
 describe('makeEventBatch', () => {
     it('should build a batch with single impression event when experiment and variation are defined', () => {
-    // FSSDK-12813: campaign_id, experiment_id, variation_id, and entity_id
-    // are normalized to numeric-strings on the wire. Test fixtures use valid
-    // numeric IDs so the happy-path output matches expectations.
+    // Fixtures use valid numeric IDs so the wire output matches the
+    // post-normalization happy-path expectations.
     const impressionEvent: ImpressionEvent = {
       type: 'impression',
       timestamp: 69,
@@ -128,10 +127,9 @@ describe('makeEventBatch', () => {
   })
 
   it('should build a batch with simlge impression event when experiment and variation are not defined', () => {
-    // FSSDK-12813: When campaign_id, experiment_id, and variation_id are all
+    // When campaign_id, experiment_id, and variation_id are all
     // missing/invalid, the normalized wire output is campaign_id=null,
-    // variation_id=null, and entity_id MUST equal campaign_id byte-for-byte
-    // (FR-009). experiment_id is left as-is.
+    // variation_id=null, and entity_id mirrors campaign_id byte-for-byte.
     const impressionEvent: ImpressionEvent = {
       type: 'impression',
       timestamp: 69,
@@ -190,7 +188,6 @@ describe('makeEventBatch', () => {
                 {
                   campaign_id: null,
                   experiment_id: "",
-                  // FSSDK-12813: empty/null variation_id normalizes to null.
                   variation_id: null,
                   metadata: {
                     flag_key: 'flagKey1',
@@ -699,8 +696,7 @@ describe('makeEventBatch', () => {
         attributes: [{ entityId: 'attr1-id', key: 'attr1-key', value: 'attr1-value' }],
       },
 
-      // FSSDK-12813: Use numeric-string IDs so happy-path output is unchanged
-      // after normalization.
+      // Use numeric-string IDs so the happy-path wire output is unchanged.
       layer: {
         id: '11111',
       },
@@ -819,8 +815,8 @@ describe('makeEventBatch', () => {
 
 describe('buildLogEvent', () => {
   it('should select the correct URL based on the event context region', () => {
-    // FSSDK-12813: Use numeric-string IDs to avoid normalization side effects
-    // unrelated to the URL-region behavior being tested here.
+    // Use numeric-string IDs so normalization is a no-op here; this test
+    // only covers URL-region behavior.
     const baseEvent: ImpressionEvent = {
       type: 'impression',
       timestamp: 69,
@@ -882,27 +878,24 @@ describe('buildLogEvent', () => {
 });
 
 /**
- * FSSDK-12813: Decision-event ID normalization tests.
+ * Decision-event ID normalization tests.
  *
- * These tests pin the normalization contract for decisions[].campaign_id,
+ * Pins the normalization contract for decisions[].campaign_id,
  * decisions[].variation_id, and events[].entity_id on impression events:
  *
- *   - campaign_id MUST be a non-empty string (any character content; IDs
- *     may be opaque, e.g. "default-12345", "layer_abc"); if empty/null/
- *     missing, fall back to experiment_id; if experiment_id is also empty/
- *     null, emit null.
- *   - variation_id MUST be a non-empty decimal-digit string OR null; any
- *     invalid input (empty, whitespace, non-numeric) normalizes to null.
- *   - events[].entity_id (impression only) follows the same rule as
- *     campaign_id and MUST equal decisions[].campaign_id byte-for-byte.
- *   - The rule applies uniformly across all decision types (experiment,
+ *   - campaign_id: non-empty string (opaque IDs allowed); fall back to
+ *     experiment_id when empty/null/missing; emit null when both are
+ *     empty/null.
+ *   - variation_id: non-empty decimal-digit string OR null; any invalid
+ *     input (empty, whitespace, non-numeric) normalizes to null.
+ *   - events[].entity_id (impression only) follows the campaign_id rule
+ *     and must equal decisions[].campaign_id byte-for-byte.
+ *   - Rule applies uniformly across all decision types (experiment,
  *     feature-test, rollout, holdout) — no per-type branching.
- *   - Conversion events derive entity_id from event.id and are left
- *     unchanged.
- *   - Event dispatch is never dropped or failed by normalization, and
- *     normalization never logs.
+ *   - Conversion events derive entity_id from event.id and are unchanged.
+ *   - Normalization never drops, fails, or logs.
  */
-describe('decision event ID normalization (FSSDK-12813)', () => {
+describe('decision event ID normalization', () => {
   const baseContext = {
     accountId: 'accountId',
     projectId: 'projectId',
@@ -963,41 +956,38 @@ describe('decision event ID normalization (FSSDK-12813)', () => {
     });
 
     it('preserves an opaque non-numeric layerId unchanged', () => {
-      // FSSDK-12813: campaign_id contract is "any non-empty string". Opaque
-      // IDs like "layer_abc" or "default-12345" pass through unchanged.
+      // campaign_id contract is "any non-empty string"; opaque IDs like
+      // "layer_abc" or "default-12345" pass through unchanged.
       const decision = getDecision(
         makeImpression({ layerId: 'layer_abc', experimentId: '67890', variationId: '111', ruleType: 'experiment' })
       );
       expect(decision.campaign_id).toBe('layer_abc');
     });
 
     it('preserves a layerId with a negative sign unchanged', () => {
-      // FSSDK-12813: Any non-empty string is valid for campaign_id.
       const decision = getDecision(
         makeImpression({ layerId: '-123', experimentId: '67890', variationId: '111', ruleType: 'experiment' })
       );
       expect(decision.campaign_id).toBe('-123');
     });
 
     it('preserves a decimal-formatted layerId unchanged', () => {
-      // FSSDK-12813: Any non-empty string is valid for campaign_id.
       const decision = getDecision(
         makeImpression({ layerId: '123.45', experimentId: '67890', variationId: '111', ruleType: 'experiment' })
       );
       expect(decision.campaign_id).toBe('123.45');
     });
 
     it('preserves an exponential-notation layerId unchanged', () => {
-      // FSSDK-12813: Any non-empty string is valid for campaign_id.
       const decision = getDecision(
         makeImpression({ layerId: '1e5', experimentId: '67890', variationId: '111', ruleType: 'experiment' })
       );
       expect(decision.campaign_id).toBe('1e5');
     });
 
     it('preserves a whitespace-only layerId unchanged', () => {
-      // FSSDK-12813: Whitespace is a non-empty string; only empty string,
-      // null, and undefined trigger the experiment_id fallback.
+      // Whitespace is a non-empty string; only empty string, null, and
+      // undefined trigger the experiment_id fallback.
       const decision = getDecision(
         makeImpression({ layerId: '   ', experimentId: '67890', variationId: '111', ruleType: 'experiment' })
       );
@@ -1019,7 +1009,7 @@ describe('decision event ID normalization (FSSDK-12813)', () => {
     });
 
     it('substitutes an opaque experiment_id when layerId is null', () => {
-      // FSSDK-12813: experiment_id fallback also accepts any non-empty string.
+      // experiment_id fallback also accepts any non-empty string.
       const decision = getDecision(
         makeImpression({ layerId: null, experimentId: 'exp_42', variationId: '111', ruleType: 'experiment' })
       );
@@ -1110,8 +1100,8 @@ describe('decision event ID normalization (FSSDK-12813)', () => {
 
     ruleTypes.forEach((ruleType) => {
       it(`normalizes campaign_id identically for ruleType=${ruleType}`, () => {
-        // FSSDK-12813: null layerId triggers fallback to experiment_id; the
-        // fallback fires identically regardless of rule type.
+        // null layerId triggers fallback to experiment_id; the fallback
+        // fires identically regardless of rule type.
         const decision = getDecision(
           makeImpression({ layerId: null, experimentId: '67890', variationId: '111', ruleType })
         );
@@ -1185,9 +1175,8 @@ describe('decision event ID normalization (FSSDK-12813)', () => {
   // ---------------------------------------------------------------------------
   describe('byte-equivalent output (FR-008)', () => {
     it('produces identical JSON for two identical event inputs', () => {
-      // FSSDK-12813: identical inputs must produce identical wire output.
-      // layerId here is a valid non-empty string (passes through unchanged);
-      // variationId is non-numeric (normalizes to null).
+      // layerId here is a valid non-empty string (passes through); the
+      // variationId is non-numeric and normalizes to null.
       const e1 = makeImpression({
         layerId: 'layer_abc',
         experimentId: '67890',

lib/event_processor/event_builder/log_event.ts

@@ -161,41 +161,26 @@ function makeConversionSnapshot(conversion: ConversionEvent): Snapshot {
 }
 
 /**
- * FSSDK-12813: Non-empty string validator used to normalize campaign_id and
- * entity_id (decision-event ID fields whose contract is "any non-empty
- * string"). IDs may be opaque, e.g. "default-12345" or "layer_abc".
- *
- * Returns true if value is a string of length >= 1. Any character content is
- * accepted. Empty string, non-string types, null, and undefined are invalid.
+ * Non-empty string validator used to normalize campaign_id and entity_id.
+ * IDs may be opaque, e.g. "default-12345" or "layer_abc".
  */
 function isNonEmptyString(value: unknown): value is string {
   return typeof value === 'string' && value.length > 0;
 }
 
 /**
- * FSSDK-12813: Numeric-string validator used to normalize variation_id.
- *
- * Returns true if value is a non-empty string consisting entirely of decimal
- * digits [0-9]. Leading zeros are allowed. Whitespace, negatives, decimals,
- * exponents, non-string types, null, and undefined are all invalid.
+ * Numeric-string validator used to normalize variation_id. Returns true if
+ * value is a non-empty string of decimal digits [0-9]. Leading zeros are
+ * allowed.
  */
 function isNumericString(value: unknown): value is string {
   return typeof value === 'string' && value.length > 0 && /^[0-9]+$/.test(value);
 }
 
 /**
- * FSSDK-12813: Normalize a campaign_id / entity_id field.
- *
- * Rule (FR-001/FR-002, FR-009): if the provided id is a non-empty string
- * return it unchanged (any character content is accepted — IDs may be
- * opaque, e.g. "default-12345", "layer_abc"); otherwise substitute
- * experimentId when experimentId itself is a non-empty string. If neither
- * is valid (empty string, null, or undefined), return null so the wire
- * payload is byte-equivalent across SDKs.
- *
- * Applies uniformly to ALL decision types (experiment, feature test,
- * rollout, holdout) — there is no per-type branching here (FR-005).
- * Does not drop or fail event dispatch (FR-006) and does not log (FR-007).
+ * Normalize a campaign_id / entity_id field. Returns the provided id when
+ * it is a non-empty string; otherwise substitutes experimentId; otherwise
+ * returns null so the wire payload is byte-equivalent across SDKs.
  */
 function normalizeCampaignId(id: unknown, experimentId: unknown): string | null {
   if (isNonEmptyString(id)) {
@@ -208,13 +193,8 @@ function normalizeCampaignId(id: unknown, experimentId: unknown): string | null
 }
 
 /**
- * FSSDK-12813: Normalize a variation_id field.
- *
- * Rule (FR-003/FR-004): variation_id retains the stricter numeric-string
- * contract. If the provided id is a non-empty numeric-string return it
- * unchanged; otherwise substitute null. Applies uniformly to ALL decision
- * types (FR-005). Does not drop or fail event dispatch (FR-006) and does
- * not log (FR-007).
+ * Normalize a variation_id field. variation_id keeps the stricter
+ * numeric-string contract — non-numeric / empty input normalizes to null.
  */
 function normalizeVariationId(id: unknown): string | null {
   return isNumericString(id) ? id : null;
@@ -227,9 +207,8 @@ function makeDecisionSnapshot(event: ImpressionEvent): Snapshot {
   const variationId = variation?.id ?? ''
   const variationKey = variation ? variation.key : ''
 
-  // FSSDK-12813: Normalize decision-event IDs uniformly across all decision
-  // types (experiment, feature test, rollout, holdout). entity_id on the
-  // impression event MUST equal decisions[].campaign_id byte-for-byte (FR-009).
+  // entity_id on the impression event mirrors decisions[].campaign_id
+  // byte-for-byte so the two fields stay wire-equivalent.
   const normalizedCampaignId = normalizeCampaignId(layerId, experimentId);
   const normalizedVariationId = normalizeVariationId(variationId);
 

lib/optimizely/index.tests.js

@@ -6690,7 +6690,6 @@ describe('lib/optimizely', function() {
                         {
                           campaign_id: null,
                           experiment_id: '',
-                          // FSSDK-12813: empty/non-numeric variation_id normalizes to null on the wire.
                           variation_id: null,
                           metadata: {
                             flag_key: 'test_feature',