upd

Author: raju-opti

lib/client_factory.ts

@@ -49,6 +49,7 @@ export const getOptimizelyInstance = (config: OptimizelyFactoryConfig): Client |
       clientVersion,
       jsonSchemaValidator,
       userProfileService,
+      userProfileServiceAsync,
       defaultDecideOptions,
       disposable,
       requestHandler,
@@ -76,6 +77,7 @@ export const getOptimizelyInstance = (config: OptimizelyFactoryConfig): Client |
       clientVersion: clientVersion || CLIENT_VERSION,
       jsonSchemaValidator,
       userProfileService,
+      userProfileServiceAsync,
       defaultDecideOptions,
       disposable,
       logger,

lib/core/decision_service/index.spec.ts

@@ -98,6 +98,7 @@ const getDecisionService = (opt: DecisionServiceInstanceOpt = {}): DecisionServi
   const decisionService = new DecisionService({
     logger,
     userProfileService,
+    userProfileServiceAsync,
     UNSTABLE_conditionEvaluators: {},
     cmabService,
   });
@@ -1452,7 +1453,7 @@ describe('DecisionService', () => {
       );
     });
 
-    it.only('should use userProfileServiceAsync if available but sync user profile service is unavialable', async () => {
+    it.only('should use userProfileServiceAsync if available and sync user profile service is unavialable', async () => {
       const { decisionService, cmabService, userProfileServiceAsync } = getDecisionService({
         userProfileService: false,
         userProfileServiceAsync: true,
@@ -1498,7 +1499,6 @@ describe('DecisionService', () => {
 
       const variation = (await value)[0];
 
-      expect(variation.error).toBe(true);
       expect(variation.result).toEqual({
         experiment: config.experimentKeyMap['exp_3'],
         variation: config.variationIdMap['5001'],

lib/core/decision_service/index.ts

@@ -290,7 +290,6 @@ export class DecisionService {
       this.getDecisionFromBucketer(op, configObj, experiment, user);
 
     return decisionVariationValue.then((variationResult): Value<OP, VariationResult> => {
-      console.log('variationResult', variationResult);
       decideReasons.push(...variationResult.reasons);
       if (variationResult.error) {
         return Value.of(op, {
@@ -336,7 +335,6 @@ export class DecisionService {
         this.updateUserProfile(experiment, variation, userProfileTracker);
       }
 
-      console.log('variationResult', variationResult.result);
       return Value.of(op, {
         result: { variationKey: variation.key, cmabUuid: variationResult.result.cmabUuid },
         reasons: decideReasons,
@@ -425,7 +423,6 @@ export class DecisionService {
         };
       }
     ).catch((ex: any) => {
-      console.log('cmab error got ....', ex)
       this.logger?.error(CMAB_FETCH_FAILED, experiment.key);
       return {
         error: true,
@@ -1160,7 +1157,6 @@ export class DecisionService {
       decideReasons.push(...decisionVariation.reasons);
 
       if (decisionVariation.error) {
-        console.log('reasons are ,,,', decideReasons, decisionVariation.reasons);
         return Value.of(op, {
           error: true,
           result: {
@@ -1645,7 +1641,6 @@ export class DecisionService {
     const decisionVariationValue = this.resolveVariation(op, configObj, rule, user, decideOptions, userProfileTracker);
 
     return decisionVariationValue.then((variationResult) => {
-      // console.log('variationResult a', variationResult);
       decideReasons.push(...variationResult.reasons);
       return Value.of(op, {
         error: variationResult.error,

lib/optimizely/index.ts

@@ -36,6 +36,7 @@ import {
   FeatureVariableValue,
   OptimizelyDecision,
   Client,
+  UserProfileServiceAsync,
 } from '../shared_types';
 import { newErrorDecision } from '../optimizely_decision';
 import OptimizelyUserContext from '../optimizely_user_context';
@@ -130,6 +131,7 @@ export type OptimizelyOptions = {
   };
   logger?: LoggerFacade;
   userProfileService?: UserProfileService | null;
+  userProfileServiceAsync?: UserProfileServiceAsync | null;
   defaultDecideOptions?: OptimizelyDecideOption[];
   odpManager?: OdpManager;
   vuidManager?: VuidManager
@@ -228,6 +230,7 @@ export default class Optimizely extends BaseService implements Client {
 
     this.decisionService = createDecisionService({
       userProfileService: userProfileService,
+      userProfileServiceAsync: config.userProfileServiceAsync || undefined,
       cmabService: config.cmabService,
       logger: this.logger,
       UNSTABLE_conditionEvaluators: config.UNSTABLE_conditionEvaluators,

lib/shared_types.ts

@@ -366,6 +366,7 @@ export interface Config {
   errorNotifier?: OpaqueErrorNotifier;
   // user profile that contains user information
   userProfileService?: UserProfileService;
+  userProfileServiceAsync?: UserProfileServiceAsync;
   // dafault options for decide API
   defaultDecideOptions?: OptimizelyDecideOption[];
   clientEngine?: string;