[FSSDK-12865] error message improv. + test addition

Author: junaed-optimizely

lib/message/error_message.ts

@@ -87,6 +87,7 @@ export const OUT_OF_BOUNDS =
 export const REQUEST_TIMEOUT = 'Request timeout';
 export const REQUEST_ERROR = 'Request error';
 export const NO_STATUS_CODE_IN_RESPONSE = 'No status code in response';
+export const INVALID_REQUEST_URL = 'Invalid request URL: %s';
 export const UNSUPPORTED_PROTOCOL = 'Unsupported protocol: %s';
 export const RETRY_CANCELLED = 'Retry cancelled';
 export const ONLY_POST_REQUESTS_ARE_SUPPORTED = 'Only POST requests are supported';

lib/utils/http_request_handler/request_handler.node.spec.ts

@@ -173,6 +173,12 @@ describe('NodeRequestHandler', () => {
       await expect(request.responsePromise).rejects.toThrow();
     });
 
+    it('should return a rejected response promise when the URL is malformed', async () => {
+      const request = nodeRequestHandler.makeRequest('not a valid url', {}, 'get');
+
+      await expect(request.responsePromise).rejects.toThrow();
+    });
+
     it('should return a rejected promise when there is a request error', async () => {
       const scope = nock(host)
         .get(path)

lib/utils/http_request_handler/request_handler.node.ts

@@ -19,7 +19,7 @@ import { AbortableRequest, Headers, RequestHandler, Response } from './http';
 import decompressResponse from 'decompress-response';
 import { LoggerFacade } from '../../logging/logger';
 import { REQUEST_TIMEOUT_MS } from '../enums';
-import { NO_STATUS_CODE_IN_RESPONSE, REQUEST_ERROR, REQUEST_TIMEOUT, UNSUPPORTED_PROTOCOL } from 'error_message';
+import { INVALID_REQUEST_URL, NO_STATUS_CODE_IN_RESPONSE, REQUEST_ERROR, REQUEST_TIMEOUT, UNSUPPORTED_PROTOCOL } from 'error_message';
 import { OptimizelyError } from '../../error/optimizly_error';
 import { Platform } from '../../platform_support';
 /**
@@ -50,7 +50,7 @@ export class NodeRequestHandler implements RequestHandler {
       parsedUrl = new URL(requestUrl);
     } catch {
       return {
-        responsePromise: Promise.reject(new OptimizelyError(UNSUPPORTED_PROTOCOL, requestUrl)),
+        responsePromise: Promise.reject(new OptimizelyError(INVALID_REQUEST_URL, requestUrl)),
         abort: () => {},
       };
     }