[FSSDK-12759] fix content-length header in NodeRequestHandler

Author: raju-opti

lib/utils/http_request_handler/request_handler.node.spec.ts

@@ -16,6 +16,7 @@
 
 import { describe, beforeEach, afterEach, beforeAll, afterAll, it, vi, expect } from 'vitest';
 
+import http from 'http';
 import nock from 'nock';
 import zlib from 'zlib';
 import { NodeRequestHandler } from './request_handler.node';
@@ -202,6 +203,90 @@ describe('NodeRequestHandler', () => {
       scope.done();
     });
 
+    describe('content-length header', () => {
+      let server: http.Server;
+      let port: number;
+      let receivedContentLength: string | undefined;
+      let receivedBodyByteLength: number;
+
+      beforeAll(async () => {
+        nock.enableNetConnect('localhost');
+        server = http.createServer((req, res) => {
+          receivedContentLength = req.headers['content-length'];
+
+          const chunks: Buffer[] = [];
+          req.on('data', (chunk: Buffer) => chunks.push(chunk));
+          req.on('end', () => {
+            receivedBodyByteLength = Buffer.concat(chunks).length;
+            res.writeHead(200, { 'content-type': 'application/json' });
+            res.end(JSON.stringify({ ok: true }));
+          });
+        });
+
+        await new Promise<void>((resolve) => {
+          server.listen(0, () => {
+            port = (server.address() as { port: number }).port;
+            resolve();
+          });
+        });
+      });
+
+      afterAll(async () => {
+        await new Promise<void>((resolve) => server.close(() => resolve()));
+        nock.disableNetConnect();
+      });
+
+      it('should set correct content-length for ASCII-only data', async () => {
+        const data = '{"key":"value"}';
+
+        const { responsePromise } = nodeRequestHandler.makeRequest(
+          `http://localhost:${port}/test`,
+          { 'content-type': 'application/json' },
+          'POST',
+          data,
+        );
+        await responsePromise;
+
+        const expectedByteLength = Buffer.byteLength(data, 'utf8');
+        expect(Number(receivedContentLength)).toBe(expectedByteLength);
+        expect(Number(receivedContentLength)).toBe(receivedBodyByteLength);
+      });
+
+      it('should set correct content-length for multi-byte UTF-8 data (emoji)', async () => {
+        const data = JSON.stringify({ message: '🚀 launch' });
+
+        const { responsePromise } = nodeRequestHandler.makeRequest(
+          `http://localhost:${port}/test`,
+          { 'content-type': 'application/json' },
+          'POST',
+          data,
+        );
+        await responsePromise;
+
+        const expectedByteLength = Buffer.byteLength(data, 'utf8');
+        expect(data.length).not.toBe(expectedByteLength);
+        expect(Number(receivedContentLength)).toBe(expectedByteLength);
+        expect(Number(receivedContentLength)).toBe(receivedBodyByteLength);
+      });
+
+      it('should set correct content-length for multi-byte UTF-8 data (CJK characters)', async () => {
+        const data = JSON.stringify({ greeting: '你好世界' });
+
+        const { responsePromise } = nodeRequestHandler.makeRequest(
+          `http://localhost:${port}/test`,
+          { 'content-type': 'application/json' },
+          'POST',
+          data,
+        );
+        await responsePromise;
+
+        const expectedByteLength = Buffer.byteLength(data, 'utf8');
+        expect(data.length).not.toBe(expectedByteLength);
+        expect(Number(receivedContentLength)).toBe(expectedByteLength);
+        expect(Number(receivedContentLength)).toBe(receivedBodyByteLength);
+      });
+    });
+
     describe('timeout', () => {
       beforeEach(() => {
         vi.useFakeTimers();

lib/utils/http_request_handler/request_handler.node.ts

@@ -62,16 +62,13 @@ export class NodeRequestHandler implements RequestHandler {
       headers: {
         ...headers,
         'accept-encoding': 'gzip,deflate',
-        'content-length': String(data?.length || 0)
+        'content-length': String(data ? Buffer.byteLength(data) : 0),
       },
       timeout: this.timeout,
     });
     const abortableRequest = this.getAbortableRequestFromRequest(request);
 
-    if (data) {
-      request.write(data);
-    }
-    request.end();
+    request.end(data);
 
     return abortableRequest;
   }